src/trusted/validator_x86/testdata/64/read_const_ptr.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/read_const_ptr.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: rebase master Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 @hex:

2 # Example of referencing memory with a constant value.

3 23 0C 25 FF FF FF FF

4 @val:

5 VALIDATOR: Checking jump targets: 0 to 7

6 VALIDATOR: Checking that basic blocks are aligned

7 * <input> is safe *

8 @rval:

9 VALIDATOR: 0000000000000000: 23 0c 25 ff ff ff ff and %ecx, [-0x1]

10 VALIDATOR: ERROR: No base register specified in memory offset

11 VALIDATOR: Checking jump targets: 0 to 7

12 VALIDATOR: Checking that basic blocks are aligned

13 * <input> IS UNSAFE *

14 @rvald:

15 VALIDATOR: 0000000000000000: 23 0c 25 ff ff ff ff and %ecx, [-0x1]

16 VALIDATOR: ERROR: No base register specified in memory offset

17 VALIDATOR: Checking block alignment and jump targets: 0 to 7

18 * <input> IS UNSAFE *

19 @vd-rval:

20 VALIDATOR: 0000000000000000: 23 0c 25 ff ff ff ff and %ecx, [-0x1]

21 VALIDATOR: ERROR: No base register specified in memory offset

22 VALIDATOR: Checking jump targets: 0 to 7

23 VALIDATOR: Checking that basic blocks are aligned

24 * <input> IS UNSAFE *

25 @dis:

26 0000000000000000: 23 0c 25 ff ff ff ff and %ecx, [-0x1 ]

27 @vdis:

28 0000000000000000: 23 0c 25 ff ff ff ff and %ecx, [-0x1 ]

29 @rdfa_output:

30 0: [0] improper memory address - bad base

31 return code: 1

OLD	NEW