src/trusted/validator_x86/testdata/64/pop-rbp.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/pop-rbp.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: rebase master Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 @hex:

2 # Test that we catch the assignment to rbp in a pop.

3 5D

4 @val:

5 VALIDATOR: 0000000000000000: 5d pop %rbp

6 VALIDATOR: ERROR: Illegal change to register RBP

7 VALIDATOR: Checking jump targets: 0 to 1

8 VALIDATOR: Checking that basic blocks are aligned

9 * <input> IS UNSAFE *

10 @rval:

11 VALIDATOR: 0000000000000000: 5d pop %rbp

12 VALIDATOR: ERROR: Illegal change to register RBP

13 VALIDATOR: Checking jump targets: 0 to 1

14 VALIDATOR: Checking that basic blocks are aligned

15 * <input> IS UNSAFE *

16 @rvald:

17 VALIDATOR: 0000000000000000: 5d pop %rbp

18 VALIDATOR: ERROR: Illegal change to register RBP

19 VALIDATOR: Checking block alignment and jump targets: 0 to 1

20 * <input> IS UNSAFE *

21 @vd-rval:

22 VALIDATOR: 0000000000000000: 5d pop %rbp

23 VALIDATOR: ERROR: Illegal change to register RBP

24 VALIDATOR: Checking jump targets: 0 to 1

25 VALIDATOR: Checking that basic blocks are aligned

26 * <input> IS UNSAFE *

27 @dis:

28 0000000000000000: 5d pop %rbp

29 @vdis:

30 0000000000000000: 5d pop %rbp

31 @rdfa_output:

32 0: [0] error - %bpl or %bp is changed

33 return code: 1

OLD	NEW