src/trusted/validator_x86/testdata/64/indirect_jmp_masked.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/indirect_jmp_masked.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: rebase master Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
	(Empty)
1 @hex:

2 # Model a case where an indirect jump is properly masked.

3 # and %edx, 0xe0

4 83 e2 e0

5 # add %rdx, %r15

6 4c 01 fa

7 # jmp %rdx

8 ff e2

9 #

10 # Model a case where an indirect jump is no longer properly masked.

11 # and %edx, 0xe0

12 83 e2 e0

13 # lea %r9, [%r15+%rdx*1]

14 4D 8D 0C 17

15 # jmp %r9

16 41 FF E1

17

18 @val:

19 VALIDATOR: 000000000000000f: 41 ff e1 jmp %r9

20 VALIDATOR: ERROR: Invalid indirect jump

21 VALIDATOR: Checking jump targets: 0 to 12

22 VALIDATOR: Checking that basic blocks are aligned

23 * <input> IS UNSAFE *

24 @rval:

25 VALIDATOR: 000000000000000f: 41 ff e1 jmp %r9

26 VALIDATOR: ERROR: Invalid indirect jump

27 VALIDATOR: Checking jump targets: 0 to 12

28 VALIDATOR: Checking that basic blocks are aligned

29 * <input> IS UNSAFE *

30 @rvald:

31 VALIDATOR: 000000000000000f: 41 ff e1 jmp %r9

32 VALIDATOR: ERROR: Invalid indirect jump

33 VALIDATOR: Checking block alignment and jump targets: 0 to 12

34 * <input> IS UNSAFE *

35 @vd-rval:

36 VALIDATOR: 000000000000000f: 41 ff e1 [P] dontcarejump %rip (s), %r9 (u)

37 VALIDATOR: ERROR: Invalid indirect jump

38 VALIDATOR: Checking jump targets: 0 to 12

39 VALIDATOR: Checking that basic blocks are aligned

40 * <input> IS UNSAFE *

41 @dis:

42 0000000000000000: 83 e2 e0 and %edx, 0xe0

43 0000000000000003: 4c 01 fa add %rdx, %r15

44 0000000000000006: ff e2 jmp %rdx

45 0000000000000008: 83 e2 e0 and %edx, 0xe0

46 000000000000000b: 4d 8d 0c 17 lea %r9, [%r15+ %rdx*1]

47 000000000000000f: 41 ff e1 jmp %r9

48 @vdis:

49 0000000000000000: 83 e2 e0 and %edx, 0xe0

50 0000000000000003: 4c 01 fa add %rdx, %r15

51 0000000000000006: ff e2 [P] dontcarejum p %rip (s), %rdx (u)

52 0000000000000008: 83 e2 e0 and %edx, 0xe0

53 000000000000000b: 4d 8d 0c 17 lea %r9, [%r15+ %rdx*1]

54 000000000000000f: 41 ff e1 [P] dontcarejum p %rip (s), %r9 (u)

55 @rdfa_output:

56 f: [0] unrecognized instruction

57 return code: 1

OLD	NEW