src/trusted/validator_x86/testdata/64/bswap.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/bswap.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: rebase master Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 @hex:

2 # Test handling of different sizes for instruction bswap.

3 # 32-bit example

4 0f c8

5 # 64-bit example

6 48 0f c8

7 # Bad case, we should not parse 16-bit operands

8 66 0f c8

9

10 @rval:

11 VALIDATOR: 0000000000000005: 66 0f c8 inva lid

12 VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction

13 VALIDATOR: 0000000000000005: 66 0f c8 inva lid

14 VALIDATOR: ERROR: Use of DATA16 (66) prefix for instruction not allowed by Nat ive Client

15 VALIDATOR: Checking jump targets: 0 to 8

16 VALIDATOR: Checking that basic blocks are aligned

17 * <input> IS UNSAFE *

18 @dis:

19 0000000000000000: 0f c8 bswap %eax

20 0000000000000002: 48 0f c8 bswap %rax

21 0000000000000005: 66 0f c8 invalid

22 @vdis:

23 0000000000000000: 0f c8 [P] dontcare %e ax (su)

24 0000000000000002: 48 0f c8 [P] dontcare %r ax (su)

25 0000000000000005: 66 0f c8 invalid

26 @rdfa_output:

27 5: [0] unrecognized instruction

28 return code: 1

OLD	NEW