src/trusted/validator_x86/testdata/64/bsf-mask.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/bsf-mask.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: rebase master Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 @hex:

2 # Test if we disallow bsf to zero-extend (i.e. mask) a memory reference.

3 0f bc c3

4 49 89 14 07

5 @rval:

6 VALIDATOR: 0000000000000003: 49 89 14 07 mov [%r15+%rax*1], %rdx

7 VALIDATOR: ERROR: Invalid index register in memory offset

8 VALIDATOR: Checking jump targets: 0 to 7

9 VALIDATOR: Checking that basic blocks are aligned

10 * <input> IS UNSAFE *

11 @rvald:

12 VALIDATOR: 0000000000000003: 49 89 14 07 mov [%r15+%rax*1], %rdx

13 VALIDATOR: ERROR: Invalid index register in memory offset

14 VALIDATOR: Checking block alignment and jump targets: 0 to 7

15 * <input> IS UNSAFE *

16 @vd-rval:

17 VALIDATOR: 0000000000000003: 49 89 14 07 mov [%r15+%rax*1], %rdx

18 VALIDATOR: ERROR: Invalid index register in memory offset

19 VALIDATOR: Checking jump targets: 0 to 7

20 VALIDATOR: Checking that basic blocks are aligned

21 * <input> IS UNSAFE *

22 @dis:

23 0000000000000000: 0f bc c3 bsf %eax, %ebx

24 0000000000000003: 49 89 14 07 mov [%r15+%rax* 1], %rdx

25 @vdis:

26 0000000000000000: 0f bc c3 [P] dontcare %e ax (s), %ebx (u)

27 0000000000000003: 49 89 14 07 mov [%r15+%rax* 1], %rdx

28 @rdfa_output:

29 3: [0] improper memory address - bad index

30 return code: 1

OLD	NEW