src/trusted/validator_x86/testdata/64/add_rsp_r15.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/add_rsp_r15.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: rebase master Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 @hex:

2 # Show that "add %rsp, %r15" doesn't work without proper previous instruction.

3 # See test lea-add-rsp.dis for an example of a proper previous instruction.

4 4c 01 fc

5 @val:

6 VALIDATOR: 0000000000000000: 4c 01 fc add %rsp, %r15

7 VALIDATOR: ERROR: Illegal assignment to RSP

8 VALIDATOR: Checking jump targets: 0 to 3

9 VALIDATOR: Checking that basic blocks are aligned

10 * <input> IS UNSAFE *

11 @rval:

12 VALIDATOR: 0000000000000000: 4c 01 fc add %rsp, %r15

13 VALIDATOR: ERROR: Illegal assignment to RSP

14 VALIDATOR: Checking jump targets: 0 to 3

15 VALIDATOR: Checking that basic blocks are aligned

16 * <input> IS UNSAFE *

17 @rvald:

18 VALIDATOR: 0000000000000000: 4c 01 fc add %rsp, %r15

19 VALIDATOR: ERROR: Illegal assignment to RSP

20 VALIDATOR: Checking block alignment and jump targets: 0 to 3

21 * <input> IS UNSAFE *

22 @vd-rval:

23 VALIDATOR: 0000000000000000: 4c 01 fc add %rsp, %r15

24 VALIDATOR: ERROR: Illegal assignment to RSP

25 VALIDATOR: Checking jump targets: 0 to 3

26 VALIDATOR: Checking that basic blocks are aligned

27 * <input> IS UNSAFE *

28 @dis:

29 0000000000000000: 4c 01 fc add %rsp, %r15

30 @vdis:

31 0000000000000000: 4c 01 fc add %rsp, %r15

32 @rdfa_output:

33 0: [0] improper %rsp sandboxing

34 return code: 1

OLD	NEW