src/trusted/validator_x86/testdata/32/bad-jmp.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/32/bad-jmp.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: rebase master Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 @hex:

2 # Example of jumping to the middle of an instruction.

3 7f ff f4

4 @nval:

5 VALIDATOR: 1: Bad jump target

6 * <input> IS UNSAFE *

7 @nvals:

8 VALIDATOR: 1: Bad jump target

9 * <input> IS UNSAFE *

10

11 Opcode Histogram;

12 1 0x7f 1 0xf4

13 Analysis Summary:

14 2 Checked instructions

15 2 checked jump targets

16 0 calls/jumps need dynamic checking (0.00%)

17

18 Problems:

19 0 illegal instructions

20 1 bad jump targets

21 0 illegal unprotected indirect jumps (including ret)

22 0 instruction alignment defects

23 0 segmentation errors

24 0 bad prefix

25 0 bad instruction length

26 0 internal errors

27 @nvalds:

28 VALIDATOR: 0: Doesn't jump to instruction address

29 * <input> IS UNSAFE *

30

31 Opcode Histogram;

32 1 0x7f 1 0xf4

33 Analysis Summary:

34 2 Checked instructions

35 1 checked jump targets

36 0 calls/jumps need dynamic checking (0.00%)

37

38 Problems:

39 0 illegal instructions

40 1 bad jump targets

41 0 illegal unprotected indirect jumps (including ret)

42 0 instruction alignment defects

43 0 segmentation errors

44 0 bad prefix

45 0 bad instruction length

46 0 internal errors

47 @dis:

48 00000000: 7f ff jnle 0x1

49 00000002: f4 hlt

50 @vdis:

51 0: 7f ff jg 0x1

52 2: f4 hlt

53 @rdfa_output:

54 0: [0] bad jump target

55 return code: 1

56 @validators_disagree:

57 Because rdfaval reported jump location, not target.

OLD	NEW