src/trusted/validator_x86/testdata/32/addr16.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/32/addr16.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: rebase master Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 @hex:

2 # Doesn't disassemble correctly

3 # 16-bit instructions

4 # mov %ax, (%bx)

5 67 66 89 07

6 # mov %ax, (%bp)

7 67 66 89 46 00

8 @nval:

9 VALIDATOR: 0: Bad prefix usage

10 VALIDATOR: 4: Bad prefix usage

11 * <input> IS UNSAFE *

12 @dis:

13 00000000: 67 66 89 07 mov NaClIllegal, %ax

14 00000004: 67 66 89 46 00 mov NaClIllegal, %ax

15 @vdis:

16 0: 67 66 89 07 mov NaClIllegal, %eax

17 4: 67 66 89 46 00 mov NaClIllegal, %eax

18 @rdfa_output:

19 0: [0] unrecognized instruction

20 4: [1] unrecognized instruction

21 return code: 1

OLD	NEW