Delete old x86 validator.

tests/stubout_mode/nacl.scons

 # -*- python -*-
 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 Import('env')
 
 if 'TRUSTED_ENV' not in env:
   Return()
 
@@ skipping 27 matching lines @@
 stubout_tool = env['TRUSTED_ENV'].File(
     '${STAGING_DIR}/${PROGPREFIX}ncval_stubout${PROGSUFFIX}')
 
 partly_invalid_nexe = env.ComponentProgram('partly_invalid', 'partly_invalid.c',
                                            EXTRA_LIBS=['${NONIRT_LIBS}'])
 
 
 # R-DFA does not support stubout mode but we need to create at least file
 # partly_invalid.nexe used in PPAPI tests thus we first create a rule for
 # this file and only then bail out.
-if env.Bit('validator_ragel'):
+# TODO(shyamsundarr): given that neither arm not x86 support stubout mode
+# and mips tests aren't run on bots, investigate deleting.
+if env.Bit('build_x86'):

[Mark Seaborn, 2014/10/06 17:47:55]

This disables the rest of the file on both x86 and ARM.  There's not much point
keeping the code below only for MIPS (which isn't tested on the bots).  How
about doing a separate cleanup change to remove this code from this point
downwards?

[shyamsundarr, 2014/10/06 23:06:57]

Done here for now but i will break it out if i split this into multiple changes.

   Return()
 
 partly_invalid_stubout_nexe = env.File('partly_invalid_stubout${PROGSUFFIX}')
 
 node = env.Command(
     target=partly_invalid_stubout_nexe,
     source=[stubout_tool, partly_invalid_nexe],
     action=[Action('${SOURCES[0]} ${SOURCES[1]} -o $TARGET')])
 # This alias is to ensure this test works with built_elsewhere=1,
 # because with that option CommandSelLdrTestNacl() assumes all its
@@ skipping 49 matching lines @@
 # offline should be equivalent to using sel_ldr's "-s" option.
 # This tool exists only for x86.
 node = env.CommandSelLdrTestNacl(
     'partly_invalid_stubout.out',
     partly_invalid_stubout_nexe,
     stdout_golden=env.File('with_stubout.stdout'),
     exit_status='untrusted_sigsegv')
 env.AddNodeToTestSuite(node, test_suites, 'run_offline_stubout_test',
                        is_broken=(env.Bit('target_mips32') or
                                   testing_on_asan_or_valgrind))