src/trusted/validator_x86/testdata/64/xchg_xadd_mem.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/xchg_xadd_mem.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 @hex:

2 # Special behavior of prod. validator: xchg with memory is not considered

3 # zero-extending.

4

5 # xchg %esi, (%rbp)

6 87 75 00

7 # sub (%rbp, %rsi, 1), %bl

8 2a 5c 35 00

9

10 # xadd %edx, (%rsp)

11 0f c1 14 24

12 # and %bh, (%rbp,%rdx)

13 20 7c 15 00

14 @rval:

15 VALIDATOR: 0000000000000003: 2a 5c 35 00 sub %bl, [%rbp+%rsi*1]

16 VALIDATOR: ERROR: Invalid index register in memory offset

17 VALIDATOR: 000000000000000b: 20 7c 15 00 and [%rbp+%rdx*1], %bh

18 VALIDATOR: ERROR: Invalid index register in memory offset

19 VALIDATOR: Checking jump targets: 0 to f

20 VALIDATOR: Checking that basic blocks are aligned

21 * <input> IS UNSAFE *

22 @dis:

23 0000000000000000: 87 75 00 xchg [%rbp], %e si

24 0000000000000003: 2a 5c 35 00 sub %bl, [%rbp+ %rsi*1]

25 0000000000000007: 0f c1 14 24 xadd [%rsp], %e dx

26 000000000000000b: 20 7c 15 00 and [%rbp+%rdx* 1], %bh

27 @rdfa_output:

28 3: [0] improper memory address - bad index

29 b: [0] improper memory address - bad index

30 return code: 1

OLD	NEW