src/trusted/validator_x86/testdata/64/shl_alias.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/shl_alias.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« src/trusted/validator_x86/testdata/64/mov-lea-rbp-bad-4.test ('K') | « src/trusted/validator_x86/testdata/64/segment_store.test ('k') | src/trusted/validator_x86/testdata/64/size_error.test » ('j') | tests/stubout_mode/nacl.scons » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 @hex:

2

3 # For background, see:

4 # http://code.google.com/p/nativeclient/issues/detail?id=2576

5

6 # "/4" encoding of SHL. This is what assemblers generate.

7 d3 e7

8 d1 e7

9 c1 e7 02

10

11 # "/6" encoding of SHL. This is an alias encoding, which we should

12 # disallow on the grounds of minimalism.

13 d3 f7

14 d1 f7

15 c1 f7 02

16 @val:

17 VALIDATOR: 0000000000000007: d3 f7 shl %edi, %cl

18 VALIDATOR: ERROR: This instruction has been marked illegal by Native Client

19 VALIDATOR: 0000000000000009: d1 f7 shl %edi, 0x1

20 VALIDATOR: ERROR: This instruction has been marked illegal by Native Client

21 VALIDATOR: 000000000000000b: c1 f7 02 shl %edi, 0x2

22 VALIDATOR: ERROR: This instruction has been marked illegal by Native Client

23 VALIDATOR: Checking jump targets: 0 to e

24 VALIDATOR: Checking that basic blocks are aligned

25 * <input> IS UNSAFE *

26 @rval:

27 VALIDATOR: 0000000000000007: d3 f7 shl %edi, %cl

28 VALIDATOR: ERROR: This instruction has been marked illegal by Native Client

29 VALIDATOR: 0000000000000009: d1 f7 shl %edi, 0x1

30 VALIDATOR: ERROR: This instruction has been marked illegal by Native Client

31 VALIDATOR: 000000000000000b: c1 f7 02 shl %edi, 0x2

32 VALIDATOR: ERROR: This instruction has been marked illegal by Native Client

33 VALIDATOR: Checking jump targets: 0 to e

34 VALIDATOR: Checking that basic blocks are aligned

35 * <input> IS UNSAFE *

36 @dis:

37 0000000000000000: d3 e7 shl %edi, %cl

38 0000000000000002: d1 e7 shl %edi, 0x1

39 0000000000000004: c1 e7 02 shl %edi, 0x2

40 0000000000000007: d3 f7 shl %edi, %cl

41 0000000000000009: d1 f7 shl %edi, 0x1

42 000000000000000b: c1 f7 02 shl %edi, 0x2

43 @rdfa_output:

44 7: [0] unrecognized instruction

45 9: [1] unrecognized instruction

46 b: [2] unrecognized instruction

47 return code: 1

OLD	NEW