src/trusted/validator_x86/testdata/64/rex_not_last.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/rex_not_last.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« src/trusted/validator_x86/testdata/64/mov-lea-rbp-bad-4.test ('K') | « src/trusted/validator_x86/testdata/64/rex_invalid.test ('k') | src/trusted/validator_x86/testdata/64/rip-relative.test » ('j') | tests/stubout_mode/nacl.scons » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 @hex:

2 # Complain about instruction where REX byte is not last.

3 # Use instruction: lock cmpxchg16b (%rax)

4 # Start by showing we accept when REX is last.

5 f0 48 0f c7 08

6 # Now show that we don't accept when REX is not last.

7 48 f0 0f c7 08

8 @rval:

9 VALIDATOR: 0000000000000000: f0 48 0f c7 08 cmpx chg16b [%rax]

10 VALIDATOR: ERROR: Invalid base register in memory offset

11 VALIDATOR: 0000000000000005: 48 f0 0f c7 08 cmpx chg16b [%rax]

12 VALIDATOR: ERROR: REX prefix byte must appear last

13 VALIDATOR: 0000000000000005: 48 f0 0f c7 08 cmpx chg16b [%rax]

14 VALIDATOR: ERROR: Invalid base register in memory offset

15 VALIDATOR: Checking jump targets: 0 to a

16 VALIDATOR: Checking that basic blocks are aligned

17 * <input> IS UNSAFE *

18 @rvald:

19 VALIDATOR: 0000000000000000: f0 48 0f c7 08 cmpx chg16b [%rax]

20 VALIDATOR: ERROR: Invalid base register in memory offset

21 VALIDATOR: 0000000000000005: 48 f0 0f c7 08 cmpx chg16b [%rax]

22 VALIDATOR: ERROR: REX prefix byte must appear last

23 VALIDATOR: 0000000000000005: 48 f0 0f c7 08 cmpx chg16b [%rax]

24 VALIDATOR: ERROR: Invalid base register in memory offset

25 VALIDATOR: Checking block alignment and jump targets: 0 to a

26 * <input> IS UNSAFE *

27 @vd-rval:

28 VALIDATOR: 0000000000000000: f0 48 0f c7 08 [P] dontcare %rdx (su), %eax (su), [%rax] (su)

29 VALIDATOR: ERROR: Invalid base register in memory offset

30 VALIDATOR: 0000000000000005: 48 f0 0f c7 08 [P] dontcare %rdx (su), %eax (su), [%rax] (su)

31 VALIDATOR: ERROR: REX prefix byte must appear last

32 VALIDATOR: 0000000000000005: 48 f0 0f c7 08 [P] dontcare %rdx (su), %eax (su), [%rax] (su)

33 VALIDATOR: ERROR: Invalid base register in memory offset

34 VALIDATOR: Checking jump targets: 0 to a

35 VALIDATOR: Checking that basic blocks are aligned

36 * <input> IS UNSAFE *

37 @dis:

38 0000000000000000: f0 48 0f c7 08 cmpxchg16b [%ra x]

39 0000000000000005: 48 f0 0f c7 08 cmpxchg16b [%ra x]

40 @vdis:

41 0000000000000000: f0 48 0f c7 08 [P] dontcare %r dx (su), %eax (su), [%rax] (su)

42 0000000000000005: 48 f0 0f c7 08 [P] dontcare %r dx (su), %eax (su), [%rax] (su)

43 @rdfa_output:

44 0: [0] improper memory address - bad base

45 5: [0] unrecognized instruction

46 return code: 1

OLD	NEW