src/trusted/validator_x86/testdata/64/restricted_registers.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/restricted_registers.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 @hex:

2 # mov %esi, %ecx

3 89 f1

4 # mov %rbp, %rsp

5 48 89 ec

6 # mov (%rsp, %rcx), %ebx

7 8b 1c 0c

8 @rval:

9 VALIDATOR: 0000000000000005: 8b 1c 0c mov %ebx, [%rsp+%rcx*1]

10 VALIDATOR: ERROR: Invalid index register in memory offset

11 VALIDATOR: Checking jump targets: 0 to 8

12 VALIDATOR: Checking that basic blocks are aligned

13 * <input> IS UNSAFE *

14 @dis:

15 0000000000000000: 89 f1 mov %ecx, %esi

16 0000000000000002: 48 89 ec mov %rsp, %rbp

17 0000000000000005: 8b 1c 0c mov %ebx, [%rsp +%rcx*1]

18 @rdfa_output:

19 5: [0] improper memory address - bad index

20 return code: 1

21 ----------------------------------------------------------------------

22 @hex:

23 # mov %esi, %ecx

24 89 f1

25 # mov %rsp, %rbp

26 48 89 e5

27 # mov (%rsp, %rcx), %ebx

28 8b 1c 0c

29 @rval:

30 VALIDATOR: 0000000000000005: 8b 1c 0c mov %ebx, [%rsp+%rcx*1]

31 VALIDATOR: ERROR: Invalid index register in memory offset

32 VALIDATOR: Checking jump targets: 0 to 8

33 VALIDATOR: Checking that basic blocks are aligned

34 * <input> IS UNSAFE *

35 @dis:

36 0000000000000000: 89 f1 mov %ecx, %esi

37 0000000000000002: 48 89 e5 mov %rbp, %rsp

38 0000000000000005: 8b 1c 0c mov %ebx, [%rsp +%rcx*1]

39 @rdfa_output:

40 5: [0] improper memory address - bad index

41 return code: 1

OLD	NEW