src/trusted/validator_x86/testdata/64/nacl_illegal.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/nacl_illegal.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 @hex:

2 # Example of an instruction marked illegal by native client.

3 # ret

4 c3

5 @val:

6 VALIDATOR: 0000000000000000: c3 ret

7 VALIDATOR: ERROR: This instruction has been marked illegal by Native Client

8 VALIDATOR: 0000000000000000: c3 ret

9 VALIDATOR: ERROR: Illegal assignment to RSP

10 VALIDATOR: Checking jump targets: 0 to 1

11 VALIDATOR: Checking that basic blocks are aligned

12 * <input> IS UNSAFE *

13 @rval:

14 VALIDATOR: 0000000000000000: c3 ret

15 VALIDATOR: ERROR: This instruction has been marked illegal by Native Client

16 VALIDATOR: 0000000000000000: c3 ret

17 VALIDATOR: ERROR: Illegal assignment to RSP

18 VALIDATOR: Checking jump targets: 0 to 1

19 VALIDATOR: Checking that basic blocks are aligned

20 * <input> IS UNSAFE *

21 @rvald:

22 VALIDATOR: 0000000000000000: c3 ret

23 VALIDATOR: ERROR: This instruction has been marked illegal by Native Client

24 VALIDATOR: 0000000000000000: c3 ret

25 VALIDATOR: ERROR: Illegal assignment to RSP

26 VALIDATOR: Checking block alignment and jump targets: 0 to 1

27 * <input> IS UNSAFE *

28 @vd-rval:

29 VALIDATOR: 0000000000000000: c3 [P] dontcare(illegal)

30 VALIDATOR: ERROR: This instruction has been marked illegal by Native Client

31 VALIDATOR: Checking jump targets: 0 to 1

32 VALIDATOR: Checking that basic blocks are aligned

33 * <input> IS UNSAFE *

34 @dis:

35 0000000000000000: c3 ret

36 @vdis:

37 0000000000000000: c3 [P] dontcare(il legal)

38 @rdfa_output:

39 0: [0] unrecognized instruction

40 return code: 1

OLD	NEW