src/trusted/validator_x86/testdata/64/mov-lea-rbp-bad-5.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/mov-lea-rbp-bad-5.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« src/trusted/validator_x86/testdata/64/mov-lea-rbp-bad-4.test ('K') | « src/trusted/validator_x86/testdata/64/mov-lea-rbp-bad-4.test ('k') | src/trusted/validator_x86/testdata/64/mov-lea-rsp.test » ('j') | tests/stubout_mode/nacl.scons » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 @hex:

2 # Bad example of using lea solution (instead of add) to update rbp.

3 # That is where we use rsp in address instead of rbp.

4 # That is, apply a mov to non 32-bit register rbp

5 # mov %rbp, %rcx

6 # lea %rbp, [%rsp+%r15*1]

7 48 89 cd

8 4a 8d 2c 3c

9 @val:

10 VALIDATOR: 0000000000000000: 48 89 cd mov %rbp, %rcx

11 VALIDATOR: ERROR: Illegal change to register RBP

12 VALIDATOR: 0000000000000003: 4a 8d 2c 3c lea %rbp, [%rsp+%r15*1]

13 VALIDATOR: ERROR: Illegal change to register RBP

14 VALIDATOR: Checking jump targets: 0 to 7

15 VALIDATOR: Checking that basic blocks are aligned

16 * <input> IS UNSAFE *

17 @rval:

18 VALIDATOR: 0000000000000000: 48 89 cd mov %rbp, %rcx

19 VALIDATOR: ERROR: Illegal change to register RBP

20 VALIDATOR: 0000000000000003: 4a 8d 2c 3c lea %rbp, [%rsp+%r15*1]

21 VALIDATOR: ERROR: Illegal change to register RBP

22 VALIDATOR: Checking jump targets: 0 to 7

23 VALIDATOR: Checking that basic blocks are aligned

24 * <input> IS UNSAFE *

25 @rvald:

26 VALIDATOR: 0000000000000000: 48 89 cd mov %rbp, %rcx

27 VALIDATOR: ERROR: Illegal change to register RBP

28 VALIDATOR: 0000000000000003: 4a 8d 2c 3c lea %rbp, [%rsp+%r15*1]

29 VALIDATOR: ERROR: Illegal change to register RBP

30 VALIDATOR: Checking block alignment and jump targets: 0 to 7

31 * <input> IS UNSAFE *

32 @vd-rval:

33 VALIDATOR: 0000000000000000: 48 89 cd mov %rbp, %rcx

34 VALIDATOR: ERROR: Illegal change to register RBP

35 VALIDATOR: 0000000000000003: 4a 8d 2c 3c lea %rbp, [%rsp+%r15*1]

36 VALIDATOR: ERROR: Illegal change to register RBP

37 VALIDATOR: Checking jump targets: 0 to 7

38 VALIDATOR: Checking that basic blocks are aligned

39 * <input> IS UNSAFE *

40 @sval:

41 Some instructions were replaced with HLTs.

42 STUBBED OUT as follows:

43 0000000000000000: f4 hlt

44 0000000000000001: f4 hlt

45 0000000000000002: f4 hlt

46 0000000000000003: f4 hlt

47 0000000000000004: f4 hlt

48 0000000000000005: f4 hlt

49 0000000000000006: f4 hlt

50 @dis:

51 0000000000000000: 48 89 cd mov %rbp, %rcx

52 0000000000000003: 4a 8d 2c 3c lea %rbp, [%rsp +%r15*1]

53 @vdis:

54 0000000000000000: 48 89 cd mov %rbp, %rcx

55 0000000000000003: 4a 8d 2c 3c lea %rbp, [%rsp +%r15*1]

56 @rdfa_output:

57 0: [0] error - %bpl or %bp is changed

58 3: [0] error - %bpl or %bp is changed

59 return code: 1

OLD	NEW