src/trusted/validator_x86/testdata/64/jump_outside.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/jump_outside.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 @hex:

2 # direct aligned jump outside of code

3 # jmp $20

4 E9 1B 00 00 00

5 # direct unaligned jump outside of code

6 # jmp $21

7 E9 17 00 00 00

8 @rval:

9 VALIDATOR: 0000000000000005: e9 17 00 00 00 jmp 0x21

10 VALIDATOR: ERROR: Instruction jumps to bad address

11 VALIDATOR: Checking jump targets: 0 to a

12 VALIDATOR: Checking that basic blocks are aligned

13 * <input> IS UNSAFE *

14 @rvald:

15 VALIDATOR: 0000000000000005: e9 17 00 00 00 jmp 0x21

16 VALIDATOR: ERROR: Instruction jumps to bad address

17 VALIDATOR: Checking block alignment and jump targets: 0 to a

18 * <input> IS UNSAFE *

19 @vd-rval:

20 VALIDATOR: 0000000000000005: e9 17 00 00 00 [P] dontcarejump %rip (s), 0x21 (u)

21 VALIDATOR: ERROR: Instruction jumps to bad address

22 VALIDATOR: Checking jump targets: 0 to a

23 VALIDATOR: Checking that basic blocks are aligned

24 * <input> IS UNSAFE *

25 @dis:

26 0000000000000000: e9 1b 00 00 00 jmp 0x20

27 0000000000000005: e9 17 00 00 00 jmp 0x21

28 @vdis:

29 0000000000000000: e9 1b 00 00 00 [P] dontcarejum p %rip (s), 0x20 (u)

30 0000000000000005: e9 17 00 00 00 [P] dontcarejum p %rip (s), 0x21 (u)

31 @rdfa_output:

32 5: [0] direct jump out of range

33 return code: 1

OLD	NEW