src/trusted/validator_x86/testdata/64/invalid_base.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/invalid_base.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 @hex:

2 # Invalid base register in memory offset, since it isn't R15, RBP, or RSP.

3 48 89 43 36

4

5

6 @val:

7 VALIDATOR: 0000000000000000: 48 89 43 36 mov [%rbx+0x36], %rax

8 VALIDATOR: ERROR: Invalid base register in memory offset

9 VALIDATOR: Checking jump targets: 0 to 4

10 VALIDATOR: Checking that basic blocks are aligned

11 * <input> IS UNSAFE *

12 @rval:

13 VALIDATOR: 0000000000000000: 48 89 43 36 mov [%rbx+0x36], %rax

14 VALIDATOR: ERROR: Invalid base register in memory offset

15 VALIDATOR: Checking jump targets: 0 to 4

16 VALIDATOR: Checking that basic blocks are aligned

17 * <input> IS UNSAFE *

18 @rvald:

19 VALIDATOR: 0000000000000000: 48 89 43 36 mov [%rbx+0x36], %rax

20 VALIDATOR: ERROR: Invalid base register in memory offset

21 VALIDATOR: Checking block alignment and jump targets: 0 to 4

22 * <input> IS UNSAFE *

23 @vd-rval:

24 VALIDATOR: 0000000000000000: 48 89 43 36 mov [%rbx+0x36], %rax

25 VALIDATOR: ERROR: Invalid base register in memory offset

26 VALIDATOR: Checking jump targets: 0 to 4

27 VALIDATOR: Checking that basic blocks are aligned

28 * <input> IS UNSAFE *

29 @dis:

30 0000000000000000: 48 89 43 36 mov [%rbx+0x36] , %rax

31 @vdis:

32 0000000000000000: 48 89 43 36 mov [%rbx+0x36] , %rax

33 @rdfa_output:

34 0: [0] improper memory address - bad base

35 return code: 1

OLD	NEW