src/trusted/validator_x86/testdata/64/inc67.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/inc67.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« src/trusted/validator_x86/build.scons ('K') | « src/trusted/validator_x86/testdata/64/hlt.test ('k') | src/trusted/validator_x86/testdata/64/inc_dec.test » ('j') | src/trusted/validator_x86/testdata/64/mov-lea-rbp-bad-4.test » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 @hex:

2 # Show that we don't accept the 67 prefix (i.e. 16 bit addressing).

3 # Uses case of rip relative addressing.

4 67 ff 05 a4 76 39 00

5 @val:

6 VALIDATOR: 0000000000000000: 67 ff 05 a4 76 39 00 inc [%rip+0x3976a4]

7 VALIDATOR: ERROR: Use of 67 (ADDR16) prefix not allowed by Native Client

8 VALIDATOR: 0000000000000000: 67 ff 05 a4 76 39 00 inc [%rip+0x3976a4]

9 VALIDATOR: ERROR: Assignment to non-64 bit memory address

10 VALIDATOR: Checking jump targets: 0 to 7

11 VALIDATOR: Checking that basic blocks are aligned

12 * <input> IS UNSAFE *

13 @rval:

14 VALIDATOR: 0000000000000000: 67 ff 05 a4 76 39 00 inc [%rip+0x3976a4]

15 VALIDATOR: ERROR: Use of 67 (ADDR16) prefix not allowed by Native Client

16 VALIDATOR: 0000000000000000: 67 ff 05 a4 76 39 00 inc [%rip+0x3976a4]

17 VALIDATOR: ERROR: Assignment to non-64 bit memory address

18 VALIDATOR: Checking jump targets: 0 to 7

19 VALIDATOR: Checking that basic blocks are aligned

20 * <input> IS UNSAFE *

21 @rvald:

22 VALIDATOR: 0000000000000000: 67 ff 05 a4 76 39 00 inc [%rip+0x3976a4]

23 VALIDATOR: ERROR: Use of 67 (ADDR16) prefix not allowed by Native Client

24 VALIDATOR: 0000000000000000: 67 ff 05 a4 76 39 00 inc [%rip+0x3976a4]

25 VALIDATOR: ERROR: Assignment to non-64 bit memory address

26 VALIDATOR: Checking block alignment and jump targets: 0 to 7

27 * <input> IS UNSAFE *

28 @vd-rval:

29 VALIDATOR: 0000000000000000: 67 ff 05 a4 76 39 00 [P] dontcare [%rip+0x3976a4] (suz)

30 VALIDATOR: ERROR: Use of 67 (ADDR16) prefix not allowed by Native Client

31 VALIDATOR: 0000000000000000: 67 ff 05 a4 76 39 00 [P] dontcare [%rip+0x3976a4] (suz)

32 VALIDATOR: ERROR: Assignment to non-64 bit memory address

33 VALIDATOR: Checking jump targets: 0 to 7

34 VALIDATOR: Checking that basic blocks are aligned

35 * <input> IS UNSAFE *

36 @dis:

37 0000000000000000: 67 ff 05 a4 76 39 00 inc [%rip+0x397 6a4]

38 @vdis:

39 0000000000000000: 67 ff 05 a4 76 39 00 [P] dontcare [% rip+0x3976a4] (suz)

40 @rdfa_output:

41 0: [0] unrecognized instruction

42 return code: 1

OLD	NEW