src/trusted/validator_x86/testdata/64/direct-cond-jump-16.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/direct-cond-jump-16.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 @hex:

2 # This file tests how we handle a 16-bit conditional direct jump. In particula r,

3 # it tests whether we actually disallow prefix 66 on direct jumps.

4 #

5 # Define direct (16-bit) conditional jump, which NaCl doesn't allow

6 66 0f 84 05 00

7

8 # Padding in case the parser of the previous instruction recognizes

9 # the wrong byte length for the jump constant.

10 90 90 90

11 @rval:

12 VALIDATOR: 0000000000000000: 66 0f 84 inva lid

13 VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction

14 VALIDATOR: 0000000000000000: 66 0f 84 inva lid

15 VALIDATOR: ERROR: Use of DATA16 (66) prefix for instruction not allowed by Nat ive Client

16 VALIDATOR: Checking jump targets: 0 to 8

17 VALIDATOR: Checking that basic blocks are aligned

18 * <input> IS UNSAFE *

19 @dis:

20 0000000000000000: 66 0f 84 invalid

21 0000000000000003: 05 00 90 90 90 add %eax, 0x909 09000

22 @rdfa_output:

23 0: [0] unrecognized instruction

24 return code: 1

OLD	NEW