src/trusted/validator_x86/testdata/64/direct-call-16.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/direct-call-16.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« src/trusted/validator_x86/build.scons ('K') | « src/trusted/validator_x86/testdata/64/data66prefix.test ('k') | src/trusted/validator_x86/testdata/64/direct-call-32.test » ('j') | src/trusted/validator_x86/testdata/64/mov-lea-rbp-bad-4.test » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 @hex:

2 # This file tests how we handle a 16-bit direct call. In particular, it tests

3 # whether we actually disallow prefix 66 on the direct call.

4 #

5 # Pad with nops, so that call is bundle aligned.

6 90 90 90 90 90 90 90 90

7 90 90 90 90 90 90 90 90

8 90 90 90 90 90 90 90 90

9 90 90 90

10

11 # Define 16-bit direct call.

12 66 e8 F0 FF

13

14 # Padding in case the parser of the previous instruction recognizes

15 # the wrong byte length for the jump constant.

16 90 90

17 @rval:

18 VALIDATOR: 000000000000001b: 66 e8 inva lid

19 VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction

20 VALIDATOR: 000000000000001b: 66 e8 inva lid

21 VALIDATOR: ERROR: Use of DATA16 (66) prefix for instruction not allowed by Nat ive Client

22 VALIDATOR: 000000000000001d: f0 ff 90 inva lid

23 VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction

24 VALIDATOR: Checking jump targets: 0 to 21

25 VALIDATOR: Checking that basic blocks are aligned

26 * <input> IS UNSAFE *

27 @dis:

28 0000000000000000: 90 nop

29 0000000000000001: 90 nop

30 0000000000000002: 90 nop

31 0000000000000003: 90 nop

32 0000000000000004: 90 nop

33 0000000000000005: 90 nop

34 0000000000000006: 90 nop

35 0000000000000007: 90 nop

36 0000000000000008: 90 nop

37 0000000000000009: 90 nop

38 000000000000000a: 90 nop

39 000000000000000b: 90 nop

40 000000000000000c: 90 nop

41 000000000000000d: 90 nop

42 000000000000000e: 90 nop

43 000000000000000f: 90 nop

44 0000000000000010: 90 nop

45 0000000000000011: 90 nop

46 0000000000000012: 90 nop

47 0000000000000013: 90 nop

48 0000000000000014: 90 nop

49 0000000000000015: 90 nop

50 0000000000000016: 90 nop

51 0000000000000017: 90 nop

52 0000000000000018: 90 nop

53 0000000000000019: 90 nop

54 000000000000001a: 90 nop

55 000000000000001b: 66 e8 invalid

56 000000000000001d: f0 ff 90 invalid

57 0000000000000020: 90 nop

58 @rdfa_output:

59 1b: [0] unrecognized instruction

60 return code: 1

61 @validators_disagree:

62 errors reported by old validator but not by rdfa one:

63 0x1d - old validator recovered in the middle of the jump

64 instruction, thus second spurious error

OLD	NEW