src/trusted/validator_x86/testdata/64/data66prefix.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/data66prefix.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 @hex:

2 # Example showing that we don't default to non-66 prefix, when there non-66

3 # prefix form doesn't allow opt-in 66 prefix.

4 #

5 # pslldq without 66 prefix.

6 0f 73 ff 00

7 @rval:

8 VALIDATOR: 0000000000000000: 0f 73 ff inva lid

9 VALIDATOR: ERROR: This instruction has been marked illegal by Native Client

10 VALIDATOR: 0000000000000000: 0f 73 ff inva lid

11 VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction

12 VALIDATOR: 0000000000000003: 00 inva lid

13 VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction

14 VALIDATOR: Checking jump targets: 0 to 4

15 VALIDATOR: Checking that basic blocks are aligned

16 * <input> IS UNSAFE *

17 @dis:

18 0000000000000000: 0f 73 ff invalid

19 0000000000000003: 00 invalid

20 @vdis:

21 0000000000000000: 0f 73 ff invalid

22 0000000000000003: 00 invalid

23 @rdfa_output:

24 0: [0] unrecognized instruction

25 return code: 1

26 @validators_disagree:

27 Because of error recovery.

28 ----------------------------------------------------------------------

29 @hex:

30 # pslldq with proper 66 prefix.

31 66 0f 73 ff 00

32 @rval:

33 VALIDATOR: Checking jump targets: 0 to 5

34 VALIDATOR: Checking that basic blocks are aligned

35 * <input> is safe *

36 @dis:

37 0000000000000000: 66 0f 73 ff 00 pslldq %xmm7, 0 x0

38 @vdis:

39 0000000000000000: 66 0f 73 ff 00 [P] dontcare %x mm7 (su), 0x0 (u)

40 @rdfa_output:

41 return code: 0

OLD	NEW