src/trusted/validator_x86/testdata/32/mem_overflow.test - Issue 625923004: Delete old x86 validator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/32/mem_overflow.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« src/trusted/validator_x86/build.scons ('K') | « src/trusted/validator_x86/testdata/32/lzcnt.test ('k') | src/trusted/validator_x86/testdata/32/ncdis_examples1.input » ('j') | src/trusted/validator_x86/testdata/64/mov-lea-rbp-bad-4.test » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 @hex:

2 # Align instruction of interest at the end of the bundle

3 90 90 90 90

4 90 90 90 90

5 90 90 90 90

6 90 90 90 90

7 90 90 90 90

8 90 90 90 90

9 90 90 90 90

10

11 # Test if we fill in (zero) for memory overflow of instruction:

12 # 00000000: 03 1d 20 00 00 00 add %ebx, 0x20

13 03 1d 20 00

14 @nval:

15 22 > 20 (read overflow of 2 bytes)

16 ErrorSegmentation

17 * <input> IS UNSAFE *

18 @dis:

19 00000000: 90 nop

20 00000001: 90 nop

21 00000002: 90 nop

22 00000003: 90 nop

23 00000004: 90 nop

24 00000005: 90 nop

25 00000006: 90 nop

26 00000007: 90 nop

27 00000008: 90 nop

28 00000009: 90 nop

29 0000000a: 90 nop

30 0000000b: 90 nop

31 0000000c: 90 nop

32 0000000d: 90 nop

33 0000000e: 90 nop

34 0000000f: 90 nop

35 00000010: 90 nop

36 00000011: 90 nop

37 00000012: 90 nop

38 00000013: 90 nop

39 00000014: 90 nop

40 00000015: 90 nop

41 00000016: 90 nop

42 00000017: 90 nop

43 00000018: 90 nop

44 00000019: 90 nop

45 0000001a: 90 nop

46 0000001b: 90 nop

47 0000001c: 03 1d invalid

48 0000001e: 20 00 and %ds:[%eax], %al

49 @vdis:

50 0: 90 nop

51 1: 90 nop

52 2: 90 nop

53 3: 90 nop

54 4: 90 nop

55 5: 90 nop

56 6: 90 nop

57 7: 90 nop

58 8: 90 nop

59 9: 90 nop

60 a: 90 nop

61 b: 90 nop

62 c: 90 nop

63 d: 90 nop

64 e: 90 nop

65 f: 90 nop

66 10: 90 nop

67 11: 90 nop

68 12: 90 nop

69 13: 90 nop

70 14: 90 nop

71 15: 90 nop

72 16: 90 nop

73 17: 90 nop

74 18: 90 nop

75 19: 90 nop

76 1a: 90 nop

77 1b: 90 nop

78 22 > 20 (read overflow of 2 bytes)

79 ErrorSegmentation

80 @rdfa_output:

81 1c: [0] unrecognized instruction

82 return code: 1

83 @validators_disagree:

84 Disagreement on error reporting, not on the essence.

85 errors reported by old validator but not by rdfa one:

86 ErrorSegmentation

87 read overflow

88 errors reported by rdfa validator but not by old one:

89 0x1c

OLD	NEW