Delete old x86 validator.

src/trusted/validator/nacl.scons

 # -*- python -*-
 # Copyright 2011 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 Import('env')
 
 if 'TRUSTED_ENV' not in env:
   Return()
 
 # This environment variable tells the test how to invoke nacl-gcc.  It
 # is slightly hacky, but seems easier than trying to describe the test
 # fixture creation in Scons.
 if env.Bit('build_x86_32'):
   env_vars = 'NACL_CFLAGS=-m32'
 elif env.Bit('build_x86_64'):
   env_vars = 'NACL_CFLAGS=-m64'
 else:
   Return()
 
 env.PrependENVPath('PATH', env['TRUSTED_ENV'].SubstList2('${STAGING_DIR}'))
-dependencies = [env['TRUSTED_ENV'].File('${STAGING_DIR}/ncval${PROGSUFFIX}'),
-               ]
+dependencies = [
+    env['TRUSTED_ENV'].File('${STAGING_DIR}/ncval_new${PROGSUFFIX}'),]

[Mark Seaborn, 2014/10/06 17:47:55]

How about doing a cleanup first to rename "ncval_new" to "ncval"?

[shyamsundarr, 2014/10/06 23:06:57]

i have left a TODO in SConstruct. i think this needs to be a separate and
careful cleanup because ncval_new has references outside of our src repo like
the native_client_sdk build?

 
 node = env.CommandTest(
     'ncval_annotate_test.out',
     command=['${PYTHON}', env.File('ncval_annotate_test.py'), '-v'],
     extra_deps=dependencies,
     osenv=env_vars)
 env.AddNodeToTestSuite(node, ['small_tests'], 'run_ncval_annotate_test',
                        # PNaCl does not allow the inline assembly that
                        # we use to test this.
                        is_broken=env.Bit('bitcode'))