Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: Source/core/rendering/RenderFlowThread.h

Issue 625903004: [New Multicolumn] Correct paint rectangle calculation for compositing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: code review. Have RenderLayer::location() behave like before for old multicol. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above 8 * 1. Redistributions of source code must retain the above
9 * copyright notice, this list of conditions and the following 9 * copyright notice, this list of conditions and the following
10 * disclaimer. 10 * disclaimer.
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 RenderRegion* lastRegion() const; 95 RenderRegion* lastRegion() const;
96 96
97 virtual bool addForcedRegionBreak(LayoutUnit, RenderObject* breakChild, bool isBefore, LayoutUnit* offsetBreakAdjustment = 0) { return false; } 97 virtual bool addForcedRegionBreak(LayoutUnit, RenderObject* breakChild, bool isBefore, LayoutUnit* offsetBreakAdjustment = 0) { return false; }
98 98
99 virtual bool isPageLogicalHeightKnown() const { return true; } 99 virtual bool isPageLogicalHeightKnown() const { return true; }
100 bool pageLogicalSizeChanged() const { return m_pageLogicalSizeChanged; } 100 bool pageLogicalSizeChanged() const { return m_pageLogicalSizeChanged; }
101 101
102 void collectLayerFragments(LayerFragments&, const LayoutRect& layerBoundingB ox, const LayoutRect& dirtyRect); 102 void collectLayerFragments(LayerFragments&, const LayoutRect& layerBoundingB ox, const LayoutRect& dirtyRect);
103 LayoutRect fragmentsBoundingBox(const LayoutRect& layerBoundingBox); 103 LayoutRect fragmentsBoundingBox(const LayoutRect& layerBoundingBox);
104 104
105 LayoutPoint flowThreadPointToVisualPoint(const LayoutPoint& flowThreadPoint) const
106 {
107 return flowThreadPoint + columnOffset(flowThreadPoint);
108 }
109
105 void pushFlowThreadLayoutState(const RenderObject&); 110 void pushFlowThreadLayoutState(const RenderObject&);
106 void popFlowThreadLayoutState(); 111 void popFlowThreadLayoutState();
107 LayoutUnit offsetFromLogicalTopOfFirstRegion(const RenderBlock*) const; 112 LayoutUnit offsetFromLogicalTopOfFirstRegion(const RenderBlock*) const;
108 113
109 // Used to estimate the maximum height of the flow thread. 114 // Used to estimate the maximum height of the flow thread.
110 static LayoutUnit maxLogicalHeight() { return LayoutUnit::max() / 2; } 115 static LayoutUnit maxLogicalHeight() { return LayoutUnit::max() / 2; }
111 116
112 protected: 117 protected:
113 virtual const char* renderName() const = 0; 118 virtual const char* renderName() const = 0;
114 119
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 }; 211 };
207 212
208 template <> struct ValueToString<RenderMultiColumnSet*> { 213 template <> struct ValueToString<RenderMultiColumnSet*> {
209 static String string(const RenderMultiColumnSet* value) { return String::for mat("%p", value); } 214 static String string(const RenderMultiColumnSet* value) { return String::for mat("%p", value); }
210 }; 215 };
211 #endif 216 #endif
212 217
213 } // namespace blink 218 } // namespace blink
214 219
215 #endif // RenderFlowThread_h 220 #endif // RenderFlowThread_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/multicol/composited-relpos-simple-expected.html ('k') | Source/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698