LayoutTests/fast/multicol/composited-relpos-simple.html - Issue 625903004: [New Multicolumn] Correct paint rectangle calculation for compositing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/composited-relpos-simple.html

Issue 625903004: [New Multicolumn] Correct paint rectangle calculation for compositing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <p>The word 'PASS' should be seen below.</p>

	3 <div style="transform:translateZ(0); width:3em; height:3em; background:yellow;"> </div>
	Julien - ping for review 2014/10/03 17:50:21 In this test, the composited element is not in the In this test, the composited element is not in the flow-thread. Don't we want one where it is actually in the flow-thread? mstensho (USE GERRIT) 2014/10/03 18:51:39 It seems to be what it takes to trigger compositin Show quoted text On 2014/10/03 17:50:21, Julien Chaffraix - PST wrote: > In this test, the composited element is not in the flow-thread. Don't we want > one where it is actually in the flow-thread? It seems to be what it takes to trigger compositing on stuff inside the multicol. Is that a bug? But sure, let's move it inside. Done.
	4 <div style="-webkit-columns:2; column-fill:auto; height:13em; line-height:2em;">

	5 <br>

	6 <br>

	7 <br>

	8 <br>

	9 <br>

	10 <div style="position:relative; margin:10px; background:yellow;">PASS</div>
	Julien - ping for review 2014/10/03 17:50:21 Do we need the position: relative here? Do we need the position: relative here? mstensho (USE GERRIT) 2014/10/03 18:51:39 Yes, then it becomes a layer, and it would fail to Show quoted text On 2014/10/03 17:50:21, Julien Chaffraix - PST wrote: > Do we need the position: relative here? Yes, then it becomes a layer, and it would fail to display without my changes in RenderLayer.cpp (when allowing compositing on stuff inside flow threads in RenderLayerCompositor::canBeComposited()) mstensho (USE GERRIT) 2014/10/06 12:39:49 The reason why this one gets composited is Composi The reason why this one gets composited is CompositingReasonAssumedOverlap. CompositingReasonAssumedOverlap is set in CompositingRequirementsUpdater::updateRecursive() because currentRecursionData.m_subtreeIsCompositing is set. It's set because of the translateZ'ed DIV earlier in the document. I've changed the test case again now, so that the translateZ'ed box and the relpos actually overlap, in case someone should decide to optimize this in the future and not just assume that they overlap. That should hopefully make this test a bit more robust.
	11 </div>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/multicol/composited-relpos-simple-expected.html » ('j') | no next file with comments »