Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 625843002: DevTools: Extract workspace mapping suggesting logic from sources panel. (Closed)

Created:
6 years, 2 months ago by vsevik
Modified:
6 years, 2 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Extract workspace mapping suggesting logic from sources panel. R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183655

Patch Set 1 #

Total comments: 1

Patch Set 2 : Done #

Patch Set 3 : Done #

Patch Set 4 : Rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -141 lines) Patch
M Source/devtools/devtools.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 2 3 7 chunks +16 lines, -140 lines 0 comments Download
A Source/devtools/front_end/sources/WorkspaceMappingTip.js View 1 2 1 chunk +155 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sources/module.json View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
vsevik
PTAL
6 years, 2 months ago (2014-10-03 08:20:02 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/625843002/diff/1/Source/devtools/front_end/sources/WorkspaceMappingSuggester.js File Source/devtools/front_end/sources/WorkspaceMappingSuggester.js (right): https://codereview.chromium.org/625843002/diff/1/Source/devtools/front_end/sources/WorkspaceMappingSuggester.js#newcode11 Source/devtools/front_end/sources/WorkspaceMappingSuggester.js:11: WebInspector.WorkspaceMappingSuggester = function(sourcesPanel, workspace) WorkspaceMappingTip WorkspaceMappingHint
6 years, 2 months ago (2014-10-03 11:26:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625843002/30004
6 years, 2 months ago (2014-10-03 12:27:32 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/30032)
6 years, 2 months ago (2014-10-03 14:40:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625843002/50001
6 years, 2 months ago (2014-10-14 08:03:09 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 09:10:52 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:50001) as 183655

Powered by Google App Engine
This is Rietveld 408576698