Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1320)

Issue 62583003: [Retry][SyncFS] Implement LargestKnownChangeID handling (Closed)

Created:
7 years, 1 month ago by tzik
Modified:
7 years, 1 month ago
Reviewers:
kinuko, nhiroki
CC:
chromium-reviews, nhiroki+watch_chromium.org, kinuko+watch, tzik
Visibility:
Public.

Description

[Retry][SyncFS] Implement LargestKnownChangeID handling BUG=240165 R=kinuko@chromium.org, nhiroki@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235709

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 2

Patch Set 3 : +comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9 lines) Patch
M chrome/browser/sync_file_system/drive_backend/metadata_database.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 1 8 chunks +24 lines, -9 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tzik
PTL
7 years, 1 month ago (2013-11-18 06:33:48 UTC) #1
kinuko
rubber-stamp lgtm https://codereview.chromium.org/62583003/diff/40001/chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc (right): https://codereview.chromium.org/62583003/diff/40001/chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc#newcode755 chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc:755: ApplyNoopChangeToMetadata(&noop_file.metadata); Care to add a comment why ...
7 years, 1 month ago (2013-11-18 06:57:11 UTC) #2
nhiroki
lgtm
7 years, 1 month ago (2013-11-18 07:06:47 UTC) #3
tzik
https://codereview.chromium.org/62583003/diff/40001/chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc (right): https://codereview.chromium.org/62583003/diff/40001/chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc#newcode755 chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc:755: ApplyNoopChangeToMetadata(&noop_file.metadata); On 2013/11/18 06:57:11, kinuko wrote: > Care to ...
7 years, 1 month ago (2013-11-18 07:17:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/62583003/20003
7 years, 1 month ago (2013-11-18 07:17:43 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=225774
7 years, 1 month ago (2013-11-18 11:28:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/62583003/20003
7 years, 1 month ago (2013-11-18 11:38:51 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 11:45:22 UTC) #8
Message was sent while issue was closed.
Change committed as 235709

Powered by Google App Engine
This is Rietveld 408576698