Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 625813003: Add externs for file_manager. (Closed)

Created:
6 years, 2 months ago by fukino
Modified:
6 years, 2 months ago
Reviewers:
hirono, Dan Beam
CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add externs for file_manager. Type annotations for private APIs used in file_manager/* are generated using http://crrev.com/511943003. Enum types in idl files are annotated as strings. BUG=406995 TEST=build/gyp_chromium --depth . `find ui/file_manager -name compiled_resources.gyp` && ninja -C out/Debug Committed: https://crrev.com/899fc2d96d02358d1bb4c6ca769fe2735bdbbb52 Cr-Commit-Position: refs/heads/master@{#298219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+633 lines, -7 lines) Patch
A third_party/closure_compiler/externs/file_manager_private.js View 1 chunk +574 lines, -0 lines 0 comments Download
A third_party/closure_compiler/externs/media_player_private.js View 1 chunk +21 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/background/js/compiled_resources.gyp View 1 chunk +5 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 chunk +6 lines, -1 line 0 comments Download
M ui/file_manager/gallery/js/compiled_resources.gyp View 2 chunks +11 lines, -2 lines 0 comments Download
M ui/file_manager/image_loader/compiled_resources.gyp View 1 chunk +5 lines, -1 line 0 comments Download
M ui/file_manager/video_player/js/compiled_resources.gyp View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
fukino
dbeam@: PTAL at third_party/closure_compiler hirono@: PTAL at ui/file_manager
6 years, 2 months ago (2014-10-03 09:48:00 UTC) #2
Dan Beam
lgtm I think your TEST= line (if you want to stick to bash commands) could ...
6 years, 2 months ago (2014-10-03 18:26:25 UTC) #3
fukino
On 2014/10/03 18:26:25, Dan Beam wrote: > lgtm > > I think your TEST= line ...
6 years, 2 months ago (2014-10-06 06:19:53 UTC) #4
fukino
ping? > @hirono
6 years, 2 months ago (2014-10-06 06:57:31 UTC) #5
hirono
Sorry for late. lgtm!
6 years, 2 months ago (2014-10-06 10:38:42 UTC) #6
fukino
On 2014/10/06 10:38:42, hirono wrote: > Sorry for late. lgtm! Thanks!
6 years, 2 months ago (2014-10-06 10:39:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625813003/1
6 years, 2 months ago (2014-10-06 10:39:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4e3cafe318491edca7c203a725074be3b1b71684
6 years, 2 months ago (2014-10-06 11:16:48 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 11:17:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/899fc2d96d02358d1bb4c6ca769fe2735bdbbb52
Cr-Commit-Position: refs/heads/master@{#298219}

Powered by Google App Engine
This is Rietveld 408576698