content/browser/child_process_launcher.cc - Issue 625633002: Fix incorrect FD handling for StatsTable shared memory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/child_process_launcher.cc

Issue 625633002: Fix incorrect FD handling for StatsTable shared memory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a test Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/child_process_launcher.cc

diff --git a/content/browser/child_process_launcher.cc b/content/browser/child_process_launcher.cc

index eb87c50dc6797d07e19f15d839161804edd03956..b9573974eca8e38629b7c5c5a3eb23a1ee45fa2e 100644

--- a/content/browser/child_process_launcher.cc

+++ b/content/browser/child_process_launcher.cc

@@ -210,9 +210,8 @@ class ChildProcessLauncher::Context

base::SharedMemory::IsHandleValid(

stats_table->GetSharedMemoryHandle())) {

base::FileDescriptor fd = stats_table->GetSharedMemoryHandle();

- DCHECK(fd.auto_close);

- files_to_register->Transfer(kStatsTableSharedMemFd,

- base::ScopedFD(fd.fd));

+ DCHECK(!fd.auto_close);

+ files_to_register->Share(kStatsTableSharedMemFd, fd.fd);

}

#endif

« no previous file with comments | « no previous file | content/browser/child_process_launcher_browsertest.cc » ('j') | content/browser/child_process_launcher_browsertest.cc » ('J')