Fix incorrect FD handling for StatsTable shared memory

Fix incorrect FD handling for StatsTable shared memory

This is a regression.
The CL crrev.com/585203002 did incorrectly handle a StatsTable FD
as its ownership was passed. The ownership should be retained by
StatsTable instead.

BUG=419655
R=jam@chromium.org, creis@chromium.org

Committed: https://crrev.com/7fd88cdabc845b15b9723374a52067967d38f9e1
Cr-Commit-Position: refs/heads/master@{#297936}

[Charlie Reis, 2014-10-02 18:20:54]

Can you add a test for this, since it was a regression?

[Hajime Morrita, 2014-10-02 20:08:47]

Thanks for the review Charlie! PTAL the updated CL?

On 2014/10/02 18:20:54, Charlie Reis wrote:
> Can you add a test for this, since it was a regression?
Right. Added one.

[Charlie Reis, 2014-10-02 21:27:24]

Thanks!  Glad we'll have some coverage for that flag.  LGTM with nits.

https://codereview.chromium.org/625633002/diff/20001/content/browser/child_pr...
File content/browser/child_process_launcher_browsertest.cc (right):

https://codereview.chromium.org/625633002/diff/20001/content/browser/child_pr...
content/browser/child_process_launcher_browsertest.cc:1: // Copyright (c) 2012
The Chromium Authors. All rights reserved.
nit: Copyright 2014

https://codereview.chromium.org/625633002/diff/20001/content/browser/child_pr...
content/browser/child_process_launcher_browsertest.cc:22: NavigateToURL(shell(),
GURL("about://blank"));
nit: about:blank

[Hajime Morrita, 2014-10-02 21:49:08]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-10-02 21:50:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/625633002/40001

[Hajime Morrita, 2014-10-02 21:51:44]

Thanks for the review! Landing.

https://codereview.chromium.org/625633002/diff/20001/content/browser/child_pr...
File content/browser/child_process_launcher_browsertest.cc (right):

https://codereview.chromium.org/625633002/diff/20001/content/browser/child_pr...
content/browser/child_process_launcher_browsertest.cc:1: // Copyright (c) 2012
The Chromium Authors. All rights reserved.
On 2014/10/02 21:27:24, Charlie Reis wrote:
> nit: Copyright 2014

Done.

https://codereview.chromium.org/625633002/diff/20001/content/browser/child_pr...
content/browser/child_process_launcher_browsertest.cc:22: NavigateToURL(shell(),
GURL("about://blank"));
On 2014/10/02 21:27:24, Charlie Reis wrote:
> nit: about:blank

Done.

[commit-bot: I haz the power, 2014-10-02 22:49:05]

Committed patchset #3 (id:40001) as 2f49f7310fced31ec6de97a55df797461fee61ad

[commit-bot: I haz the power, 2014-10-02 22:50:56]

Patchset 3 (id:??) landed as
https://crrev.com/7fd88cdabc845b15b9723374a52067967d38f9e1
Cr-Commit-Position: refs/heads/master@{#297936}