Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 625593002: Support installation on Mac OS X 10.10 under gcapi (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/installer/gcapi_mac/gcapi.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
This would normally go to Nico for review, because he wrote gcapi_mac, but he’s out.
6 years, 2 months ago (2014-10-02 14:50:09 UTC) #2
pink (ping after 24hrs)
lgtm
6 years, 2 months ago (2014-10-02 14:51:35 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6ffeea1aef1ea57db082b1de93082e556a931b00 Cr-Commit-Position: refs/heads/master@{#297845}
6 years, 2 months ago (2014-10-02 16:20:52 UTC) #4
Mark Mentovai
6 years, 2 months ago (2014-10-02 16:20:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6ffeea1aef1ea57db082b1de93082e556a931b00 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698