Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: Source/core/dom/Document.cpp

Issue 625583002: Properly suspend HTMLDocumentParser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: better way to call m_parserScheduler->resume Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index 15e51deb36a65c9ccb46505c25af707ba6b79846..3413eb3b1111c2a9787523f78e86fe6da54d5c04 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -548,6 +548,12 @@ Document::Document(const DocumentInit& initializer, DocumentClassFlags documentC
// m_fetcher.
m_styleEngine = StyleEngine::create(*this);
+ // The parent's parser should be suspended together with all the other objects,
+ // else this new Document would have a new ExecutionContext which suspended state
+ // would not match the one from the parent, and could start loading resources
+ // ignoring the defersLoading flag.
+ ASSERT(!parentDocument() || !parentDocument()->activeDOMObjectsAreSuspended());
+
#ifndef NDEBUG
liveDocumentSet().add(this);
#endif

Powered by Google App Engine
This is Rietveld 408576698