Properly suspend HTMLDocumentParser

Source/core/page/ScopedPageLoadDeferrer.cpp

 /*
  * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 28 matching lines @@
         if (page == exclusion || page->defersLoading())
             continue;
 
         if (page->mainFrame()->isLocalFrame()) {
             m_deferredFrames.append(page->deprecatedLocalMainFrame());
 
             // Ensure that we notify the client if the initial empty document is accessed before
             // showing anything modal, to prevent spoofs while the modal window or sheet is visible.
             page->deprecatedLocalMainFrame()->loader().notifyIfInitialDocumentAccessed();
         }
-
-        // This code is not logically part of load deferring, but we do not want JS code executed
-        // beneath modal windows or sheets, which is exactly when ScopedPageLoadDeferrer is used.
-        for (Frame* frame = page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
-            if (frame->isLocalFrame())
-                toLocalFrame(frame)->document()->suspendScheduledTasks();

[João Eiras, 2014/10/06 12:14:31]

I moved this code into FrameLoader::setDefersLoading() where it feels it belongs
better. It will also make the Page to FrameHost migration easier.

-        }
     }
 
     size_t count = m_deferredFrames.size();
     for (size_t i = 0; i < count; ++i) {
         if (Page* page = m_deferredFrames[i]->page())
             page->setDefersLoading(true);
     }
 }
 
 void ScopedPageLoadDeferrer::detach()
 {
     for (size_t i = 0; i < m_deferredFrames.size(); ++i) {
-        if (Page* page = m_deferredFrames[i]->page()) {
+        if (Page* page = m_deferredFrames[i]->page())
             page->setDefersLoading(false);
-
-            for (Frame* frame = page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
-                if (frame->isLocalFrame())
-                    toLocalFrame(frame)->document()->resumeScheduledTasks();
-            }
-        }
     }
 }
 
 #if ENABLE(OILPAN)
 void ScopedPageLoadDeferrer::dispose()
 {
     detach();
     m_deferredFrames.clear();
 }
 #endif
 
 ScopedPageLoadDeferrer::~ScopedPageLoadDeferrer()
 {
     detach();
 }
 
 void ScopedPageLoadDeferrer::trace(Visitor* visitor)
 {
 #if ENABLE(OILPAN)
     visitor->trace(m_deferredFrames);
 #endif
 }
 
 } // namespace blink