Source/core/html/parser/HTMLDocumentParser.h - Issue 625583002: Properly suspend HTMLDocumentParser

Side by Side Diff: Source/core/html/parser/HTMLDocumentParser.h

Issue 625583002: Properly suspend HTMLDocumentParser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: better way to call m_parserScheduler->resume Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/parser/html-document-parser-suspended-40.html ('K') | « Source/core/dom/ExecutionContext.cpp ('k') | Source/core/html/parser/HTMLDocumentParser.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google, Inc. All Rights Reserved.	2 * Copyright (C) 2010 Google, Inc. All Rights Reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 181 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
192 // so they can be set and cleared together and passed between threads togeth er.	192 // so they can be set and cleared together and passed between threads togeth er.

193 OwnPtr<ParsedChunk> m_lastChunkBeforeScript;	193 OwnPtr<ParsedChunk> m_lastChunkBeforeScript;

194 Deque<OwnPtr<ParsedChunk>> m_speculations;	194 Deque<OwnPtr<ParsedChunk>> m_speculations;

195 WeakPtrFactory<HTMLDocumentParser> m_weakFactory;	195 WeakPtrFactory<HTMLDocumentParser> m_weakFactory;

196 WeakPtr<BackgroundHTMLParser> m_backgroundParser;	196 WeakPtr<BackgroundHTMLParser> m_backgroundParser;

197 OwnPtrWillBeMember<HTMLResourcePreloader> m_preloader;	197 OwnPtrWillBeMember<HTMLResourcePreloader> m_preloader;

198	198

199 bool m_isPinnedToMainThread;	199 bool m_isPinnedToMainThread;

200 bool m_endWasDelayed;	200 bool m_endWasDelayed;

201 bool m_haveBackgroundParser;	201 bool m_haveBackgroundParser;

	202 bool m_tasksWereSuspended;
	kouhei (in TOK) 2014/11/19 07:56:10 Would you move this flag under HTMLParserScheduler Would you move this flag under HTMLParserScheduler? I think the flag is more well-fitted there. João Eiras 2014/11/27 01:18:38 Btw, what about this ? Still want me to change it Show quoted text On 2014/11/19 07:56:10, kouhei wrote: > Would you move this flag under HTMLParserScheduler? I think the flag is more > well-fitted there. Btw, what about this ? Still want me to change it (since you lgtm'ed the review) ? kouhei (in TOK) 2014/11/27 01:51:04 I think we should move the flag, but not necessari Show quoted text On 2014/11/27 01:18:38, João Eiras wrote: > On 2014/11/19 07:56:10, kouhei wrote: > > Would you move this flag under HTMLParserScheduler? I think the flag is more > > well-fitted there. > > Btw, what about this ? Still want me to change it (since you lgtm'ed the review) > ? I think we should move the flag, but not necessarily in this CL.
202 unsigned m_pumpSessionNestingLevel;	203 unsigned m_pumpSessionNestingLevel;

203 };	204 };

204	205

205 }	206 }

206	207

207 #endif	208 #endif

OLD	NEW