Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 625573003: TileGrid: earliest need not be a pointer anymore (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

TileGrid: earliest need not be a pointer anymore BUG=skia: Committed: https://skia.googlesource.com/skia/+/15c7ceb6aabec88ee4950135dbc74011b7446193

Patch Set 1 #

Total comments: 4

Patch Set 2 : SK_MaxU32 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M src/core/SkTileGrid.cpp View 1 1 chunk +9 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein
Turned out to be simpler than I feared...
6 years, 2 months ago (2014-10-02 14:50:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625573003/1
6 years, 2 months ago (2014-10-02 14:51:00 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-02 14:51:01 UTC) #5
robertphillips
lgtm + a suggestion https://codereview.chromium.org/625573003/diff/1/src/core/SkTileGrid.cpp File src/core/SkTileGrid.cpp (right): https://codereview.chromium.org/625573003/diff/1/src/core/SkTileGrid.cpp#newcode126 src/core/SkTileGrid.cpp:126: // tile. It may be ...
6 years, 2 months ago (2014-10-02 15:17:25 UTC) #7
mtklein
https://codereview.chromium.org/625573003/diff/1/src/core/SkTileGrid.cpp File src/core/SkTileGrid.cpp (right): https://codereview.chromium.org/625573003/diff/1/src/core/SkTileGrid.cpp#newcode126 src/core/SkTileGrid.cpp:126: // tile. It may be at the front of ...
6 years, 2 months ago (2014-10-02 15:40:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625573003/20001
6 years, 2 months ago (2014-10-02 15:42:07 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 15:50:44 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 15c7ceb6aabec88ee4950135dbc74011b7446193

Powered by Google App Engine
This is Rietveld 408576698