Respect content settings for Service Worker registration

chrome/browser/chrome_content_browser_client.cc

Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 479ecb733adc733229b647988dc0fc24e89f440d..9aec4796ea29b5500e909386b193ccc9a497f2cd 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -1461,6 +1461,16 @@ bool ChromeContentBrowserClient::AllowAppCache(
       IsSettingCookieAllowed(manifest_url, first_party);
 }
 
+bool ChromeContentBrowserClient::AllowServiceWorker(
+    const GURL& scope,
+    const GURL& document_url,
+    content::ResourceContext* context) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+  ProfileIOData* io_data = ProfileIOData::FromResourceContext(context);
+  return io_data->GetCookieSettings()->IsSettingCookieAllowed(scope,

[michaeln, 2014/10/02 20:32:51]

nit: maybe use wrapping style consistent with ln 1461 and 1484 (when in rome)

[falken, 2014/10/03 08:30:42]

Done (I'd just run git-cl format and didn't check closely)

+                                                              document_url);

[michaeln, 2014/10/02 20:46:28]

The docurl is not a good value for the 2nd param to IsSettingCookieAllowed. That
param is there to support the 'Block third-party cookies and site data' checkbox
in the settings. It should be the url of the topmost frame in the frame
hierarchy of the page poking at sw stuff.

See appcache_host.cc for how the first_party_url value can be determined and
stored.

[falken, 2014/10/03 08:30:42]

Done.

+}
+
 bool ChromeContentBrowserClient::AllowGetCookie(
     const GURL& url,
     const GURL& first_party,