Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 625503002: Get rid of src_extension_id from TtsController. (Closed)

Created:
6 years, 2 months ago by dmazzoni
Modified:
6 years, 2 months ago
Reviewers:
David Tseng, mrunal
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Get rid of src_extension_id from TtsController. TtsController doesn't need to know about it. BUG=347045 Committed: https://crrev.com/e5dbc82e98e519ce2026ddb7dac2d669c51999b1 Cr-Commit-Position: refs/heads/master@{#300538}

Patch Set 1 #

Patch Set 2 : Fix typo #

Total comments: 2

Patch Set 3 : Rebase, address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M chrome/browser/speech/extension_api/tts_extension_api.cc View 1 2 4 chunks +14 lines, -3 lines 0 comments Download
M chrome/browser/speech/tts_controller.h View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dmazzoni
6 years, 2 months ago (2014-10-02 06:12:15 UTC) #2
David Tseng
lgtm https://codereview.chromium.org/625503002/diff/20001/chrome/browser/speech/extension_api/tts_extension_api.cc File chrome/browser/speech/extension_api/tts_extension_api.cc (right): https://codereview.chromium.org/625503002/diff/20001/chrome/browser/speech/extension_api/tts_extension_api.cc#newcode97 chrome/browser/speech/extension_api/tts_extension_api.cc:97: std::string src_extension_id_; nit: migrate the [modified] comment as ...
6 years, 2 months ago (2014-10-02 22:49:38 UTC) #3
mrunal
On 2014/10/02 22:49:38, David Tseng wrote: > lgtm > > https://codereview.chromium.org/625503002/diff/20001/chrome/browser/speech/extension_api/tts_extension_api.cc > File chrome/browser/speech/extension_api/tts_extension_api.cc (right): ...
6 years, 2 months ago (2014-10-14 15:19:54 UTC) #4
dmazzoni
https://codereview.chromium.org/625503002/diff/20001/chrome/browser/speech/extension_api/tts_extension_api.cc File chrome/browser/speech/extension_api/tts_extension_api.cc (right): https://codereview.chromium.org/625503002/diff/20001/chrome/browser/speech/extension_api/tts_extension_api.cc#newcode97 chrome/browser/speech/extension_api/tts_extension_api.cc:97: std::string src_extension_id_; On 2014/10/02 22:49:38, David Tseng wrote: > ...
6 years, 2 months ago (2014-10-21 18:50:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625503002/40001
6 years, 2 months ago (2014-10-21 18:51:01 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-21 19:56:20 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 19:57:41 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e5dbc82e98e519ce2026ddb7dac2d669c51999b1
Cr-Commit-Position: refs/heads/master@{#300538}

Powered by Google App Engine
This is Rietveld 408576698