Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 625483002: OOPIF: Allow navigations on a RFH without a site to stay in same process (Closed)

Created:
6 years, 2 months ago by alexmos
Modified:
6 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

OOPIF: Allow navigations on a RFH without a site to stay in same process. This was causing failures in NavigateToURL for a few content_browsertests when running under --site-per-process. BUG=417518 Committed: https://crrev.com/d74555751144d391e0e2d05483760cb2836d8560 Cr-Commit-Position: refs/heads/master@{#297863}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/browser/loader/cross_site_resource_handler.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
alexmos
Hi Charlie, can you please take a look at this fix?
6 years, 2 months ago (2014-10-02 16:55:55 UTC) #2
Charlie Reis
LGTM. (This is in keeping with Nasko's TODO to make it behave more like UpdateStateForNavigate, ...
6 years, 2 months ago (2014-10-02 17:19:31 UTC) #3
alexmos
On 2014/10/02 17:19:31, Charlie Reis wrote: > LGTM. (This is in keeping with Nasko's TODO ...
6 years, 2 months ago (2014-10-02 17:27:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625483002/20001
6 years, 2 months ago (2014-10-02 17:27:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 8fd66cc29205164a508703b52f99f2dfc92e8f80
6 years, 2 months ago (2014-10-02 18:06:10 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 18:07:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d74555751144d391e0e2d05483760cb2836d8560
Cr-Commit-Position: refs/heads/master@{#297863}

Powered by Google App Engine
This is Rietveld 408576698