[ScreenOrientation] Add use counters.

[ScreenOrientation] Add use counters.

It counts calls to screen.orientation and separately,
counts calls to its properties and methods.

BUG=162827
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183143

[mlamouri (slow - plz ping), 2014-10-02 11:52:08]

mlamouri@chromium.org changed reviewers:
+ kenneth.r.christiansen@intel.com

[kenneth.r.christiansen, 2014-10-02 11:54:06]

LGTM. As the price is pretty low, I think we should just count unlock as well.

[Peter Beverloo, 2014-10-02 12:30:05]

peter@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2014-10-02 12:30:07]

https://codereview.chromium.org/625443004/diff/1/Source/modules/screen_orient...
File Source/modules/screen_orientation/ScreenOrientation.cpp (right):

https://codereview.chromium.org/625443004/diff/1/Source/modules/screen_orient...
Source/modules/screen_orientation/ScreenOrientation.cpp:130: if (m_frame)
Please move these to ScreenOrientation.idl using the [MeasureAs] annotation.

[mlamouri (slow - plz ping), 2014-10-02 12:59:12]

On 2014/10/02 12:30:07, Peter Beverloo wrote:
>
https://codereview.chromium.org/625443004/diff/1/Source/modules/screen_orient...
> File Source/modules/screen_orientation/ScreenOrientation.cpp (right):
> 
>
https://codereview.chromium.org/625443004/diff/1/Source/modules/screen_orient...
> Source/modules/screen_orientation/ScreenOrientation.cpp:130: if (m_frame)
> Please move these to ScreenOrientation.idl using the [MeasureAs] annotation.

Yeah. I realised when reading Kenneth comment while going for lunch that I
mostly didn't want to add unlock() to prevent adding useless code but the idl
MeasureAs would make that concern moot. Thanks for pointing that out though :)

[mlamouri (slow - plz ping), 2014-10-02 13:03:55]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2014-10-02 13:04:10]

The CQ bit was unchecked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2014-10-02 13:04:46]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-10-02 13:04:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/625443004/20001

[Peter Beverloo, 2014-10-02 13:29:34]

https://codereview.chromium.org/625443004/diff/20001/Source/modules/screen_or...
File Source/modules/screen_orientation/ScreenScreenOrientation.idl (right):

https://codereview.chromium.org/625443004/diff/20001/Source/modules/screen_or...
Source/modules/screen_orientation/ScreenScreenOrientation.idl:8:
[CallWith=ScriptState, MeasureAs=ScreenOrientation] readonly attribute
ScreenOrientation orientation;
Since you measure all properties within the ScreenOrientation individually,
what's the benefit of measuring access to the screen.orientation getter itself?

You should probably drop this one.

[Peter Beverloo, 2014-10-02 13:32:28]

The CQ bit was unchecked by peter@chromium.org

[mlamouri (slow - plz ping), 2014-10-02 14:20:19]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-10-02 14:21:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/625443004/40001

[Peter Beverloo, 2014-10-02 14:23:21]

On 2014/10/02 14:21:10, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/625443004/40001

lgtm, thanks!

[commit-bot: I haz the power, 2014-10-02 16:05:05]

Committed patchset #3 (id:40001) as 183143