content/browser/service_worker/service_worker_request_handler.h - Issue 625433002: Pages controlled by ServiceWorkers should not participate in AppCaching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_request_handler.h

Issue 625433002: Pages controlled by ServiceWorkers should not participate in AppCaching (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_provider_host.h ('k') | content/browser/service_worker/service_worker_request_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_request_handler.h

diff --git a/content/browser/service_worker/service_worker_request_handler.h b/content/browser/service_worker/service_worker_request_handler.h

index 42ac881bfc8ed6cf49e2fe763b5390c1d8365678..6ce4e03482fae791b529804c51f75ff5ce7b1f5c 100644

--- a/content/browser/service_worker/service_worker_request_handler.h

+++ b/content/browser/service_worker/service_worker_request_handler.h

@@ -69,6 +69,12 @@ class CONTENT_EXPORT ServiceWorkerRequestHandler

static scoped_ptr<net::URLRequestInterceptor> CreateInterceptor(

ResourceContext* resource_context);

+ // Returns true if the request falls into the scope of a ServiceWorker.

+ // It's only reliable after the ServiceWorkerRequestHandler MaybeCreateJob

+ // method runs to completion for this request. The AppCache handler uses

+ // this to avoid colliding with ServiceWorkers.

+ static bool IsControlledByServiceWorker(net::URLRequest* request);

virtual ~ServiceWorkerRequestHandler();

// Called via custom URLRequestJobFactory.