Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: content/browser/appcache/appcache_interceptor.h

Issue 625433002: Pages controlled by ServiceWorkers should not participate in AppCaching (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/appcache/appcache_host.cc ('k') | content/browser/appcache/appcache_interceptor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/appcache_interceptor.h
diff --git a/content/browser/appcache/appcache_interceptor.h b/content/browser/appcache/appcache_interceptor.h
index 1cb59f767a4589bc454265f0eef3322becca159f..b18fc0990b972764ae49e01808b12e8720ada17e 100644
--- a/content/browser/appcache/appcache_interceptor.h
+++ b/content/browser/appcache/appcache_interceptor.h
@@ -9,6 +9,7 @@
#include "content/common/content_export.h"
#include "content/public/common/resource_type.h"
#include "net/url_request/url_request.h"
+#include "net/url_request/url_request_interceptor.h"
#include "url/gurl.h"
namespace content {
@@ -48,6 +49,14 @@ class CONTENT_EXPORT AppCacheInterceptor
static AppCacheInterceptor* GetInstance();
+ // The appcache system employs two different interceptors. The singleton
+ // AppCacheInterceptor derives URLRequest::Interceptor and is used
+ // to hijack request handling upon receipt of the response or a redirect.
+ // A separate URLRequestInterceptor derivative is used to hijack handling
+ // at the very start of request processing. The separate handler allows the
+ // content lib to order its collection of net::URLRequestInterceptors.
+ static scoped_ptr<net::URLRequestInterceptor> CreateStartInterceptor();
+
protected:
// Override from net::URLRequest::Interceptor:
virtual net::URLRequestJob* MaybeIntercept(
@@ -63,6 +72,7 @@ class CONTENT_EXPORT AppCacheInterceptor
private:
friend struct DefaultSingletonTraits<AppCacheInterceptor>;
+ class StartInterceptor;
AppCacheInterceptor();
virtual ~AppCacheInterceptor();
« no previous file with comments | « content/browser/appcache/appcache_host.cc ('k') | content/browser/appcache/appcache_interceptor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698