Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 62543003: Added InvalidAccessError exception (Closed)

Created:
7 years, 1 month ago by landell
Modified:
7 years, 1 month ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, nessy, philipj_slow, abarth-chromium, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium, ddorwin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Added InvalidAccessError exception Platform support for this exception is missing and is needed in order to be compliant with Clearkey tests of Youtube's MSE/EME conformance suite. Test suite: http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/main.html BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162364

Patch Set 1 #

Patch Set 2 : Rebased to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/core/html/HTMLMediaElement.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/platform/graphics/media/MediaPlayer.h View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebMediaPlayer.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
landell
7 years, 1 month ago (2013-11-15 11:29:22 UTC) #1
abarth-chromium
Does this CL have an observable effects? If not, we should probably wait until we ...
7 years, 1 month ago (2013-11-15 16:00:23 UTC) #2
landell
On 2013/11/15 16:00:23, abarth wrote: > Does this CL have an observable effects? If not, ...
7 years, 1 month ago (2013-11-18 08:10:04 UTC) #3
xhwang
On 2013/11/18 08:10:04, landell wrote: > On 2013/11/15 16:00:23, abarth wrote: > > Does this ...
7 years, 1 month ago (2013-11-18 17:17:13 UTC) #4
abarth-chromium
LGTM, assuming we plan to run the conformance tests automatically.
7 years, 1 month ago (2013-11-18 17:50:23 UTC) #5
landell
Since this is my first chromium patch I am a bit unsure about the procedures. ...
7 years, 1 month ago (2013-11-19 08:59:34 UTC) #6
Mostyn Bramley-Moore
> The failing CKAddKey test is tracked by crbug.com/312820 Can you give us access to ...
7 years, 1 month ago (2013-11-19 09:11:54 UTC) #7
Daniel Bratell
On 2013/11/19 08:59:34, landell wrote: > Since this is my first chromium patch I am ...
7 years, 1 month ago (2013-11-19 10:30:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/landell@opera.com/62543003/1
7 years, 1 month ago (2013-11-19 10:42:06 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, wtf_unittests ...
7 years, 1 month ago (2013-11-19 11:19:11 UTC) #10
landell
Since the changes introduced in the rebase are trivial I assume the LGTM is still ...
7 years, 1 month ago (2013-11-20 08:59:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/landell@opera.com/62543003/100002
7 years, 1 month ago (2013-11-20 11:26:32 UTC) #12
commit-bot: I haz the power
7 years, 1 month ago (2013-11-20 13:38:51 UTC) #13
Message was sent while issue was closed.
Change committed as 162364

Powered by Google App Engine
This is Rietveld 408576698