chrome/browser/dom_ui/shown_sections_handler.cc - Issue 6254018: Allow chrome.send to pass number, boolean, null and arrays of those

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/dom_ui/shown_sections_handler.cc

Issue 6254018: Allow chrome.send to pass number, boolean, null and arrays of those (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rename function and fix indentation Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/dom_ui/shown_sections_handler.cc

diff --git a/chrome/browser/dom_ui/shown_sections_handler.cc b/chrome/browser/dom_ui/shown_sections_handler.cc

index d8f240372be279815a5854967ad080bdf8adad90..ed04b63f81da7068e2a55f935f3b53a166562e74 100644

--- a/chrome/browser/dom_ui/shown_sections_handler.cc

+++ b/chrome/browser/dom_ui/shown_sections_handler.cc

@@ -91,8 +91,8 @@ void ShownSectionsHandler::HandleGetShownSections(const ListValue* args) {

}

void ShownSectionsHandler::HandleSetShownSections(const ListValue* args) {

- int mode;

- CHECK(ExtractIntegerValue(args, &mode));

+ double mode;

+ CHECK(args->GetReal(0, &mode));

arv (Not doing code reviews) 2011/01/25 18:17:04 I'm going to do another patch to rename this to Ge

int old_mode = pref_service_->GetInteger(prefs::kNTPShownSections);

if (old_mode != mode) {

« no previous file with comments | « no previous file | chrome/browser/resources/new_new_tab.js » ('j') | no next file with comments »