Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 625263003: Replace OVERRIDE and FINAL with override and final in content/app/[a-s]* (Closed)

Created:
6 years, 2 months ago by Anand Ratn (left samsung)
Modified:
6 years, 2 months ago
Reviewers:
agl
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace OVERRIDE and FINAL with override and final in content/app/[a-s]* BUG=417463 Committed: https://crrev.com/5ced363f1ea47cc44b4c64b1375707636429be69 Cr-Commit-Position: refs/heads/master@{#298305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/app/android/child_process_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/app/content_main_runner.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Anand Ratn (left samsung)
agl@chromium.org: Please review changes in content/app module
6 years, 2 months ago (2014-10-06 10:03:30 UTC) #2
agl
lgtm
6 years, 2 months ago (2014-10-06 17:05:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625263003/1
6 years, 2 months ago (2014-10-06 17:19:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ee95645400d51b049a937e5ff55538c2229e68ee
6 years, 2 months ago (2014-10-06 23:06:44 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 23:07:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ced363f1ea47cc44b4c64b1375707636429be69
Cr-Commit-Position: refs/heads/master@{#298305}

Powered by Google App Engine
This is Rietveld 408576698