Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 62523005: [NaCl SDK] Turn off parallel GYP when building nacl_sdk. (Closed)

Created:
7 years, 1 month ago by binji
Modified:
7 years, 1 month ago
Reviewers:
Sam Clegg
CC:
chromium-reviews
Visibility:
Public.

Description

[NaCl SDK] Turn off parallel GYP when building nacl_sdk. This will make it easier to drover a change to the 1700 branch, instead of having to branch native_client to get the real fix (r12324). BUG=319564 R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
binji
7 years, 1 month ago (2013-11-15 00:19:30 UTC) #1
Sam Clegg
Why not just commit this directly to 32 and not to main at all?
7 years, 1 month ago (2013-11-15 00:44:26 UTC) #2
binji
On 2013/11/15 00:44:26, Sam Clegg wrote: > Why not just commit this directly to 32 ...
7 years, 1 month ago (2013-11-15 17:40:39 UTC) #3
Sam Clegg
On 2013/11/15 17:40:39, binji wrote: > On 2013/11/15 00:44:26, Sam Clegg wrote: > > Why ...
7 years, 1 month ago (2013-11-15 17:44:35 UTC) #4
binji
7 years, 1 month ago (2013-11-22 00:17:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r236644 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698