tools/perf/page_sets/top_desktop_sites_2012Q3.py - Issue 625123002: Make credential_path a page attribute instead of page_set attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/top_desktop_sites_2012Q3.py

Issue 625123002: Make credential_path a page attribute instead of page_set attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert changes to path & path_unittest Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/top_desktop_sites_2012Q3.py

diff --git a/tools/perf/page_sets/top_desktop_sites_2012Q3.py b/tools/perf/page_sets/top_desktop_sites_2012Q3.py

index 8ee3239784f85544528049cd19fe823a669de2cd..30d5a6a9c716cb765471325e6c7fcd19f2b2e4e4 100644

--- a/tools/perf/page_sets/top_desktop_sites_2012Q3.py

+++ b/tools/perf/page_sets/top_desktop_sites_2012Q3.py

@@ -8,9 +8,9 @@ from telemetry.page import page

class Top2012Q3Page(page.Page):

def __init__(self, url, ps):

- super(Top2012Q3Page, self).__init__(url=url, page_set=ps)

+ super(Top2012Q3Page, self).__init__(

+ url=url, page_set=ps, credentials_path = 'data/credentials.json')

self.make_javascript_deterministic = True

- self.credentials_path = 'data/credentials.json'

self.archive_data_file = 'data/2012Q3.json'

def ReloadAndGc(self, action_runner):

@@ -35,7 +35,6 @@ class Top2012Q3PageSet(page_set.PageSet):

def __init__(self):

super(Top2012Q3PageSet, self).__init__(

make_javascript_deterministic=True,

- credentials_path='data/credentials.json',

archive_data_file='data/2012Q3.json',

bucket=page_set.PARTNER_BUCKET)

« no previous file with comments | « tools/perf/page_sets/top_25.py ('k') | tools/perf/page_sets/tough_compositor_cases.py » ('j') | no next file with comments »