tools/perf/page_sets/top_10.py - Issue 625123002: Make credential_path a page attribute instead of page_set attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/top_10.py

Issue 625123002: Make credential_path a page attribute instead of page_set attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert changes to path & path_unittest Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/top_10.py

diff --git a/tools/perf/page_sets/top_10.py b/tools/perf/page_sets/top_10.py

index 7c70b8ebbc6d4657b23352094209555052527e33..4297b19fe95da86ba7e2d3a25101f1597cbc0576 100644

--- a/tools/perf/page_sets/top_10.py

+++ b/tools/perf/page_sets/top_10.py

@@ -7,7 +7,9 @@ from telemetry.page import page_set as page_set_module

class SimpleScrollPage(page_module.Page):

def __init__(self, url, page_set, credentials='', name=''):

- super(SimpleScrollPage, self).__init__(url, page_set=page_set, name=name)

+ super(SimpleScrollPage, self).__init__(

+ url, page_set=page_set, name=name,

+ credentials_path='data/credentials.json')

self.credentials = credentials

def RunSmoothness(self, action_runner):

@@ -90,7 +92,6 @@ class Top10PageSet(page_set_module.PageSet):

def __init__(self):

super(Top10PageSet, self).__init__(

archive_data_file='data/top_10.json',

- credentials_path='data/credentials.json',

user_agent_type='desktop',

bucket=page_set_module.PARTNER_BUCKET)

« no previous file with comments | « tools/perf/page_sets/simple_mobile_sites.py ('k') | tools/perf/page_sets/top_10_mobile.py » ('j') | no next file with comments »