Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: tools/telemetry/telemetry/page/page_runner_unittest.py

Issue 625123002: Make credential_path a page attribute instead of page_set attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import logging 5 import logging
6 import os 6 import os
7 import tempfile 7 import tempfile
8 import unittest 8 import unittest
9 9
10 from telemetry import benchmark 10 from telemetry import benchmark
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 def testCredentialsWhenLoginSucceeds(self): 322 def testCredentialsWhenLoginSucceeds(self):
323 credentials_backend = StubCredentialsBackend(login_return_value=True) 323 credentials_backend = StubCredentialsBackend(login_return_value=True)
324 did_run = self.runCredentialsTest(credentials_backend) 324 did_run = self.runCredentialsTest(credentials_backend)
325 assert credentials_backend.did_get_login == True 325 assert credentials_backend.did_get_login == True
326 assert credentials_backend.did_get_login_no_longer_needed == True 326 assert credentials_backend.did_get_login_no_longer_needed == True
327 assert did_run 327 assert did_run
328 328
329 def runCredentialsTest(self, credentials_backend): 329 def runCredentialsTest(self, credentials_backend):
330 ps = page_set.PageSet() 330 ps = page_set.PageSet()
331 expectations = test_expectations.TestExpectations() 331 expectations = test_expectations.TestExpectations()
332 page = page_module.Page(
333 'file://blank.html', ps, base_dir=util.GetUnittestDataDir())
334 page.credentials = "test"
335 ps.pages.append(page)
336
337 did_run = [False] 332 did_run = [False]
338 333
339 try: 334 try:
340 with tempfile.NamedTemporaryFile(delete=False) as f: 335 with tempfile.NamedTemporaryFile(delete=False) as f:
336 page = page_module.Page(
337 'file://blank.html', ps, base_dir=util.GetUnittestDataDir(),
338 credentials_path=f.name)
339 page.credentials = "test"
340 ps.pages.append(page)
341
341 f.write(SIMPLE_CREDENTIALS_STRING) 342 f.write(SIMPLE_CREDENTIALS_STRING)
342 ps.credentials_path = f.name
343 343
344 class TestThatInstallsCredentialsBackend(page_test.PageTest): 344 class TestThatInstallsCredentialsBackend(page_test.PageTest):
345 def __init__(self, credentials_backend): 345 def __init__(self, credentials_backend):
346 super(TestThatInstallsCredentialsBackend, self).__init__() 346 super(TestThatInstallsCredentialsBackend, self).__init__()
347 self._credentials_backend = credentials_backend 347 self._credentials_backend = credentials_backend
348 348
349 def DidStartBrowser(self, browser): 349 def DidStartBrowser(self, browser):
350 browser.credentials.AddBackend(self._credentials_backend) 350 browser.credentials.AddBackend(self._credentials_backend)
351 351
352 def ValidatePage(self, *_): 352 def ValidatePage(self, *_):
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
653 if ii <= expected_max_failures: 653 if ii <= expected_max_failures:
654 self.assertTrue(ps.pages[ii].was_run) 654 self.assertTrue(ps.pages[ii].was_run)
655 else: 655 else:
656 self.assertFalse(ps.pages[ii].was_run) 656 self.assertFalse(ps.pages[ii].was_run)
657 657
658 def testMaxFailuresOptionIsRespected(self): 658 def testMaxFailuresOptionIsRespected(self):
659 self._testMaxFailuresOptionIsRespectedAndOverridable() 659 self._testMaxFailuresOptionIsRespectedAndOverridable()
660 660
661 def testMaxFailuresOptionIsOverridable(self): 661 def testMaxFailuresOptionIsOverridable(self):
662 self._testMaxFailuresOptionIsRespectedAndOverridable(1) 662 self._testMaxFailuresOptionIsRespectedAndOverridable(1)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698