Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Side by Side Diff: tools/perf/page_sets/mobile_memory.py

Issue 625123002: Make credential_path a page attribute instead of page_set attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert changes to path & path_unittest Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/page_sets/key_silk_cases.py ('k') | tools/perf/page_sets/plus_alt_posts_photos.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 from telemetry.page import page as page_module 4 from telemetry.page import page as page_module
5 from telemetry.page import page_set as page_set_module 5 from telemetry.page import page_set as page_set_module
6 6
7 7
8 class MobileMemoryPage(page_module.Page): 8 class MobileMemoryPage(page_module.Page):
9 9
10 def __init__(self, url, page_set): 10 def __init__(self, url, page_set):
11 super(MobileMemoryPage, self).__init__(url=url, page_set=page_set) 11 super(MobileMemoryPage, self).__init__(
12 self.credentials_path = 'data/credentials.json' 12 url=url, page_set=page_set, credentials_path = 'data/credentials.json')
13 self.user_agent_type = 'mobile' 13 self.user_agent_type = 'mobile'
14 self.archive_data_file = 'data/mobile_memory.json' 14 self.archive_data_file = 'data/mobile_memory.json'
15 15
16 16
17 class GmailPage(MobileMemoryPage): 17 class GmailPage(MobileMemoryPage):
18 18
19 def __init__(self, page_set): 19 def __init__(self, page_set):
20 super(GmailPage, self).__init__( 20 super(GmailPage, self).__init__(
21 url='https://mail.google.com/mail/mu', 21 url='https://mail.google.com/mail/mu',
22 page_set=page_set) 22 page_set=page_set)
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 action_runner.ScrollPage() 81 action_runner.ScrollPage()
82 interaction.End() 82 interaction.End()
83 83
84 84
85 class MobileMemoryPageSet(page_set_module.PageSet): 85 class MobileMemoryPageSet(page_set_module.PageSet):
86 86
87 """ Mobile sites with interesting memory characteristics """ 87 """ Mobile sites with interesting memory characteristics """
88 88
89 def __init__(self): 89 def __init__(self):
90 super(MobileMemoryPageSet, self).__init__( 90 super(MobileMemoryPageSet, self).__init__(
91 credentials_path='data/credentials.json',
92 user_agent_type='mobile', 91 user_agent_type='mobile',
93 archive_data_file='data/mobile_memory.json', 92 archive_data_file='data/mobile_memory.json',
94 bucket=page_set_module.PARTNER_BUCKET) 93 bucket=page_set_module.PARTNER_BUCKET)
95 94
96 self.AddPage(GmailPage(self)) 95 self.AddPage(GmailPage(self))
97 self.AddPage(GoogleSearchPage(self)) 96 self.AddPage(GoogleSearchPage(self))
98 97
99 urls_list = [ 98 urls_list = [
100 # Why: Renderer process memory bloat 99 # Why: Renderer process memory bloat
101 'http://techcrunch.com', 100 'http://techcrunch.com',
102 # pylint: disable=C0301 101 # pylint: disable=C0301
103 'http://techcrunch.com/2014/02/17/pixel-brings-brings-old-school-video-gam e-art-to-life-in-your-home/', 102 'http://techcrunch.com/2014/02/17/pixel-brings-brings-old-school-video-gam e-art-to-life-in-your-home/',
104 'http://techcrunch.com/2014/02/15/kickstarter-coins-2/', 103 'http://techcrunch.com/2014/02/15/kickstarter-coins-2/',
105 'http://techcrunch.com/2014/02/15/was-y-combinator-worth-it/', 104 'http://techcrunch.com/2014/02/15/was-y-combinator-worth-it/',
106 ] 105 ]
107 106
108 for url in urls_list: 107 for url in urls_list:
109 self.AddPage(ScrollPage(url, self)) 108 self.AddPage(ScrollPage(url, self))
OLDNEW
« no previous file with comments | « tools/perf/page_sets/key_silk_cases.py ('k') | tools/perf/page_sets/plus_alt_posts_photos.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698