Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: tools/perf/page_sets/key_desktop_sites.py

Issue 625123002: Make credential_path a page attribute instead of page_set attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert changes to path & path_unittest Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/page_sets/gmail_refresh.py ('k') | tools/perf/page_sets/key_mobile_sites.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 from telemetry.page import page as page_module 4 from telemetry.page import page as page_module
5 from telemetry.page import page_set as page_set_module 5 from telemetry.page import page_set as page_set_module
6 6
7 7
8 class KeyDesktopSitesPage(page_module.Page): 8 class KeyDesktopSitesPage(page_module.Page):
9 9
10 def __init__(self, url, page_set): 10 def __init__(self, url, page_set):
11 super(KeyDesktopSitesPage, self).__init__(url=url, page_set=page_set) 11 super(KeyDesktopSitesPage, self).__init__(
12 self.credentials_path = 'data/credentials.json' 12 url=url, page_set=page_set, credentials_path = 'data/credentials.json')
13 self.archive_data_file = 'data/key_desktop_sites.json' 13 self.archive_data_file = 'data/key_desktop_sites.json'
14 14
15 def RunSmoothness(self, action_runner): 15 def RunSmoothness(self, action_runner):
16 interaction = action_runner.BeginGestureInteraction( 16 interaction = action_runner.BeginGestureInteraction(
17 'ScrollAction', is_smooth=True) 17 'ScrollAction', is_smooth=True)
18 action_runner.ScrollPage() 18 action_runner.ScrollPage()
19 interaction.End() 19 interaction.End()
20 20
21 21
22 class FacebookPage(KeyDesktopSitesPage): 22 class FacebookPage(KeyDesktopSitesPage):
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 action_runner.WaitForJavaScriptCondition( 112 action_runner.WaitForJavaScriptCondition(
113 'document.getElementsByClassName("kix-appview-editor").length') 113 'document.getElementsByClassName("kix-appview-editor").length')
114 114
115 115
116 class KeyDesktopSitesPageSet(page_set_module.PageSet): 116 class KeyDesktopSitesPageSet(page_set_module.PageSet):
117 117
118 """ Sites of Interest """ 118 """ Sites of Interest """
119 119
120 def __init__(self): 120 def __init__(self):
121 super(KeyDesktopSitesPageSet, self).__init__( 121 super(KeyDesktopSitesPageSet, self).__init__(
122 credentials_path='data/credentials.json',
123 archive_data_file='data/key_desktop_sites.json', 122 archive_data_file='data/key_desktop_sites.json',
124 bucket=page_set_module.PARTNER_BUCKET) 123 bucket=page_set_module.PARTNER_BUCKET)
125 124
126 self.AddPage(FacebookPage(self)) 125 self.AddPage(FacebookPage(self))
127 self.AddPage(GmailPage(self)) 126 self.AddPage(GmailPage(self))
128 self.AddPage(GoogleCalendarPage(self)) 127 self.AddPage(GoogleCalendarPage(self))
129 self.AddPage(GoogleDrivePage(self)) 128 self.AddPage(GoogleDrivePage(self))
130 self.AddPage(GoogleDocPage(self)) 129 self.AddPage(GoogleDocPage(self))
131 130
132 urls_list = [ 131 urls_list = [
(...skipping 712 matching lines...) Expand 10 before | Expand all | Expand 10 after
845 '&q=black%20screen%20amd&colspec=ID%20Pri%20Mstone%20ReleaseBlock%20OS' 844 '&q=black%20screen%20amd&colspec=ID%20Pri%20Mstone%20ReleaseBlock%20OS'
846 '%20Area%20Feature%20Status%20Owner%20Summary'), 845 '%20Area%20Feature%20Status%20Owner%20Summary'),
847 'http://mlb.mlb.com/index.jsp', 846 'http://mlb.mlb.com/index.jsp',
848 'http://www.nfl.com/', 847 'http://www.nfl.com/',
849 'http://airbnb.github.com/infinity/demo-on.html', 848 'http://airbnb.github.com/infinity/demo-on.html',
850 'http://habrahabr.ru/post/149892/#habracut' 849 'http://habrahabr.ru/post/149892/#habracut'
851 ] 850 ]
852 851
853 for url in urls_list: 852 for url in urls_list:
854 self.AddPage(KeyDesktopSitesPage(url, self)) 853 self.AddPage(KeyDesktopSitesPage(url, self))
OLDNEW
« no previous file with comments | « tools/perf/page_sets/gmail_refresh.py ('k') | tools/perf/page_sets/key_mobile_sites.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698